friendica/friendica-addons

Fork 13

[blockem] Cleanups: #655

Merged

Quix0r merged 4 commits from blockem/import-curly-spaces into develop

2018-07-21 03:51:16 +02:00

Quix0r commented

2018-07-20 23:16:17 +02:00

(Migrated from github.com)

used use Friendica\App;
used proper type-hints
added spaces and curly braces for better readability

- used `use Friendica\App;` - used proper type-hints - added spaces and curly braces for better readability

Quix0r commented

2018-07-20 23:17:01 +02:00

(Migrated from github.com)

If this way is okay for @MrPetovan I continue the same way with other addons.

👍 1

Quix0r (Migrated from github.com) reviewed 2018-07-20 23:19:23 +02:00

Quix0r (Migrated from github.com) left a comment

Let's fix them!

MrPetovan (Migrated from github.com) requested changes 2018-07-20 23:21:14 +02:00

MrPetovan commented

2018-07-20 23:22:14 +02:00

(Migrated from github.com)

That’s perfect. curweather indenting is all spaces for example.

Quix0r (Migrated from github.com) reviewed 2018-07-20 23:24:20 +02:00

Quix0r commented

2018-07-20 23:27:26 +02:00

(Migrated from github.com)

I found a few more lines where I missed adding spaces.

MrPetovan (Migrated from github.com) reviewed 2018-07-20 23:51:31 +02:00

MrPetovan (Migrated from github.com) requested changes 2018-07-21 02:23:58 +02:00

MrPetovan (Migrated from github.com) left a comment

Not only you changed indentation the wrong way (it should be normalized to tabs like the rest of the project), you also added 57 more files than expected! 😅

Quix0r commented

2018-07-21 03:07:44 +02:00

(Migrated from github.com)

Should be okay now.

MrPetovan (Migrated from github.com) approved these changes 2018-07-21 03:51:11 +02:00

No reviewers

MrPetovan

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#655

No description provided.