friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 2 Releases 16 Wiki Activity

[curweather] Only shown notice about unavailable weather once per session. #653

Merged
astifter merged 3 commits from curweather_fix_header into develop 2018-07-20 21:58:54 +02:00
Conversation 2 Commits 3 Files Changed 2 +120 -108
astifter commented 2018-07-20 21:04:52 +02:00 (Migrated from github.com)
Copy Link

Fix several issues in curweather widget:

Fix several issues in curweather widget: - When the widget can not load weather data, it shows a notice, this notice is shown on every page load. Also the widget is plain and blank and needs to be formated properly. * Fix: Store notification-shown-state in session and show only once per session. (See https://github.com/friendica/friendica-addons/compare/develop...astifter:curweather_fix_header?expand=1#diff-5cd1ef666d6ce6004e4e355947ed8d10R37) * Fix: Restyle error widget: Old: ![screenshot_2018-07-20 friendica social network network](https://user-images.githubusercontent.com/206846/43020509-7a3b4b28-8c60-11e8-8a08-6d56e75e4e7f.png) - Fix whitespace in PHP file.
MrPetovan (Migrated from github.com) requested changes 2018-07-20 21:14:48 +02:00
astifter commented 2018-07-20 21:32:39 +02:00 (Migrated from github.com)
Copy Link

@MrPetovan But the changes with the session are okay?

@MrPetovan But the changes with the session are okay?
MrPetovan commented 2018-07-20 21:46:52 +02:00 (Migrated from github.com)
Copy Link

My only problem with it is that you don't have a consistent timeout for showing the error again. But maybe it isn't a problem.

My only problem with it is that you don't have a consistent timeout for showing the error again. But maybe it isn't a problem.
MrPetovan (Migrated from github.com) approved these changes 2018-07-20 21:47:35 +02:00
MrPetovan (Migrated from github.com) approved these changes 2018-07-20 21:58:43 +02:00
tobiasd (Migrated from github.com) reviewed 2018-07-21 07:40:43 +02:00
MrPetovan (Migrated from github.com) reviewed 2018-07-21 13:29:54 +02:00
astifter (Migrated from github.com) reviewed 2018-07-21 22:34:22 +02:00
MrPetovan (Migrated from github.com) reviewed 2018-07-21 23:33:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#653
No description provided.
Delete Branch "curweather_fix_header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?