notifyall: enclose senders name in quotation marks #601

Merged

tobiasd merged 7 commits from 20180513-4976 into 2018.05-rc

2018-05-14 22:08:37 +02:00

tobiasd commented

2018-05-13 14:25:46 +02:00

(Migrated from github.com)

enclose the senders name construct

$nodename, Administrator

with quotation marks so it does not get interpreted as multible email addresses.

this might solve friendica/friendica#4976

enclose the *senders name* construct $nodename, Administrator with quotation marks so it does not get interpreted as multible email addresses. this might solve friendica/friendica#4976

Quix0r (Migrated from github.com) requested changes 2018-05-13 15:32:40 +02:00

Quix0r (Migrated from github.com) left a comment

Else this looks okay.

Quix0r (Migrated from github.com) reviewed 2018-05-13 15:33:13 +02:00

MrPetovan (Migrated from github.com) requested changes 2018-05-13 15:56:26 +02:00

MrPetovan (Migrated from github.com) approved these changes 2018-05-13 18:41:51 +02:00

annando (Migrated from github.com) requested changes 2018-05-13 22:19:55 +02:00

annando (Migrated from github.com) left a comment

There are some style issues - and I'm asking myself if these quotation marks are really needed.

Quix0r (Migrated from github.com) reviewed 2018-05-13 23:09:48 +02:00

Quix0r (Migrated from github.com) left a comment

Small thing is left to fix (aside what others have requested).

MrPetovan (Migrated from github.com) reviewed 2018-05-14 00:37:33 +02:00

tobiasd commented

2018-05-14 06:54:57 +02:00

(Migrated from github.com)

The thing without the quotation mark is that

adam, nodes name administrator <noreply@example.com>

is interpreted as list of local email addresses due the comma which results in a FROM field of the email with many addresses which is not correct.

Putting quotes around them

"adam, nodes name administrator" <noreply@example.com>

make the sender name "adam, nodes name administrator" with the email address "noreply@examplle.com".

The thing without the quotation mark is that adam, nodes name administrator <noreply@example.com> is interpreted as list of local email addresses due the comma which results in a FROM field of the email with many addresses which is not correct. Putting quotes around them "adam, nodes name administrator" <noreply@example.com> make the sender name "adam, nodes name administrator" with the email address "noreply@examplle.com".

tobiasd (Migrated from github.com) reviewed 2018-05-14 06:56:59 +02:00

tobiasd (Migrated from github.com) reviewed 2018-05-14 06:59:05 +02:00

MrPetovan (Migrated from github.com) requested changes 2018-05-14 14:14:01 +02:00

MrPetovan (Migrated from github.com) approved these changes 2018-05-14 15:10:45 +02:00

annando commented

2018-05-14 18:06:43 +02:00

(Migrated from github.com)

Have you checked the RFC how to do it? I have the feeling that Name <user@domain.tld> should be the correct way to write it down and that "Name" user@domain.tld is more some Microsoft Outlook "invention".

Have you checked the RFC how to do it? I have the feeling that ```Name <user@domain.tld>``` should be the correct way to write it down and that ```"Name" user@domain.tld``` is more some Microsoft Outlook "invention".

AlfredSK commented

2018-05-14 18:31:49 +02:00

(Migrated from github.com)

I would completely get rid of the name part for the From field and just use the plain sender mail address from the admin panel.
It's okay to use "$admin-name, $node-name Administrator" for the final salute (?) 😂 (don't know Grußformel in English) in the last line of the mail body. Just like we do in registration mails.

I would completely get rid of the name part for the From field and just use the plain sender mail address from the admin panel. It's okay to use "$admin-name, $node-name Administrator" for the final salute (?) 😂 (don't know Grußformel in English) in the last line of the mail body. Just like we do in registration mails.

MrPetovan commented

2018-05-14 18:37:49 +02:00

(Migrated from github.com)

Would it affect the email sender display if we removed the name? If yes, I'm against it, it's awful to receive an email from just "noreply@example.com".

tobiasd commented

2018-05-14 18:39:03 +02:00

(Migrated from github.com)

You can circumvent the list by surrounding the name with quotation marks.

The other solution is not to use a comma in the sender name. Or leave the name out of the FROM field. I actually like to see the name of my communication partner there So I opted for the quotation marks.

The problem is that there is a comma in the sender name. With that you get an address list. The parts without an actual email address are interpreted as local accounts on the sender server. If there is only spaces in the sender name, no problem. You can circumvent the list by surrounding the name with quotation marks. The other solution is not to use a comma in the sender name. Or leave the name out of the FROM field. I actually like to see the name of my communication partner there So I opted for the quotation marks.

AlfredSK commented

2018-05-14 18:40:14 +02:00

(Migrated from github.com)

Okay. I checked the From field of a "user deleted his account" mail. It looks like this:
From: LIBRANET.de <admin@libranet.de>
Better?

Okay. I checked the From field of a "user deleted his account" mail. It looks like this: `From: LIBRANET.de <admin@libranet.de>` Better?

Quix0r (Migrated from github.com) approved these changes 2018-05-14 21:54:14 +02:00

Quix0r (Migrated from github.com) left a comment

Thank you for finding these.

AlfredSK commented

2018-05-14 22:12:58 +02:00

(Migrated from github.com)

C'mon, I updated 3 minutes ago. And this was merged 2 minutes ago. 😁
Updating again...