friendica/friendica-addons

Fork 16

Cat Avatar Generator: Fix coding style #573

Merged

fabrixxm merged 3 commits from catavatar into develop

2018-04-06 18:44:09 +02:00

fabrixxm commented

2018-04-05 22:24:33 +02:00

(Migrated from github.com)

as per comments in #571

👍 1

MrPetovan (Migrated from github.com) requested changes 2018-04-05 22:41:08 +02:00

MrPetovan (Migrated from github.com) left a comment

Now that you took on yourself to write things right, I'm going to be nitpicking!

fabrixxm (Migrated from github.com) reviewed 2018-04-06 08:23:48 +02:00

tobiasd (Migrated from github.com) requested changes 2018-04-06 10:21:23 +02:00

tobiasd (Migrated from github.com) left a comment

Can you please add the extracted message strings so that they can be added to the translation pipe.

MrPetovan (Migrated from github.com) reviewed 2018-04-06 13:59:12 +02:00

fabrixxm commented

2018-04-06 18:32:12 +02:00

(Migrated from github.com)

@tobiasd added 👍
@MrPetovan ready for next round!
I know I already asked this: is there a tool to check for code style? With a config already usable?

@tobiasd added :+1: @MrPetovan ready for next round! I know I already asked this: is there a tool to check for code style? With a config already usable?

tobiasd (Migrated from github.com) approved these changes 2018-04-06 18:32:48 +02:00

MrPetovan (Migrated from github.com) approved these changes 2018-04-06 18:44:01 +02:00

MrPetovan commented

2018-04-06 20:16:09 +02:00

(Migrated from github.com)

@fabrixxm Yes, check PHP CodeSniffer out, it should use the ruleset.xml file at the project root.

@fabrixxm Yes, check PHP CodeSniffer out, it should use the `ruleset.xml` file at the project root.

👍 1

No reviewers

tobiasd

MrPetovan

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#573

No description provided.

Rows
Columns