friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 3 Releases 16 Wiki Activity

Add content_filter hook #566

Merged
MrPetovan merged 10 commits from task/add-content_filter-hook into develop 2018-04-06 06:44:01 +02:00
Conversation 3 Commits 10 Files Changed 10 +119 -112
MrPetovan commented 2018-04-01 09:01:16 +02:00 (Migrated from github.com)
Copy Link

See: https://friendica.mrpetovan.com/display/735a2029715ab80d1874cf6808556656

Depends on https://github.com/friendica/friendica/pull/4722

Please review the translation strings I added, they may not be the best way of presening the content filtering reasons.

Additionally, the showmore addon now disabled when there is a content-filter applied because of display incompatibility.

See: https://friendica.mrpetovan.com/display/735a2029715ab80d1874cf6808556656 Depends on https://github.com/friendica/friendica/pull/4722 Please review the translation strings I added, they may not be the best way of presening the content filtering reasons. Additionally, the showmore addon now disabled when there is a content-filter applied because of display incompatibility.
tobiasd (Migrated from github.com) requested changes 2018-04-01 10:25:30 +02:00
tobiasd (Migrated from github.com) left a comment
Copy Link

Can you please re-generate the messages.po files of the addons so that they can be picked up by the translation chain.

Can you please re-generate the messages.po files of the addons so that they can be picked up by the translation chain.
MrPetovan commented 2018-04-01 10:26:56 +02:00 (Migrated from github.com)
Copy Link

I'd like to wait until we agree on them as they currently are exact, but maybe too long or not friendly enough, or confusing maybe? On top of that I'm not sure about the procedure for addons.

I'd like to wait until we agree on them as they currently are exact, but maybe too long or not friendly enough, or confusing maybe? On top of that I'm not sure about the procedure for addons.
👍 1
tobiasd commented 2018-04-01 11:16:25 +02:00 (Migrated from github.com)
Copy Link

In the addon directory you want to extract the strings /path/to/run_xgettext.sh -s

In the addon directory you want to extract the strings `/path/to/run_xgettext.sh -s`
MrPetovan commented 2018-04-01 17:17:49 +02:00 (Migrated from github.com)
Copy Link

I accidentally ran /path/to/run_xgettext.sh -s in the literal /path/to/friendica/addon folder, and I found an empty translation string that triggered a notice in gettext!

I accidentally ran `/path/to/run_xgettext.sh -s` in the literal `/path/to/friendica/addon` folder, and I found an empty translation string that triggered a notice in gettext!
tobiasd (Migrated from github.com) reviewed 2018-04-02 19:01:24 +02:00
tobiasd (Migrated from github.com) approved these changes 2018-04-02 19:02:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tobiasd
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#566
No description provided.
Delete Branch "task/add-content_filter-hook"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?