Add content_filter hook #566

Merged

MrPetovan merged 10 commits from task/add-content_filter-hook into develop

2018-04-06 06:44:01 +02:00

MrPetovan commented

2018-04-01 09:01:16 +02:00

(Migrated from github.com)

See: https://friendica.mrpetovan.com/display/735a2029715ab80d1874cf6808556656

Depends on https://github.com/friendica/friendica/pull/4722

Please review the translation strings I added, they may not be the best way of presening the content filtering reasons.

Additionally, the showmore addon now disabled when there is a content-filter applied because of display incompatibility.

See: https://friendica.mrpetovan.com/display/735a2029715ab80d1874cf6808556656 Depends on https://github.com/friendica/friendica/pull/4722 Please review the translation strings I added, they may not be the best way of presening the content filtering reasons. Additionally, the showmore addon now disabled when there is a content-filter applied because of display incompatibility.

tobiasd (Migrated from github.com) requested changes 2018-04-01 10:25:30 +02:00

tobiasd (Migrated from github.com) left a comment

Can you please re-generate the messages.po files of the addons so that they can be picked up by the translation chain.

MrPetovan commented

2018-04-01 10:26:56 +02:00

(Migrated from github.com)

I'd like to wait until we agree on them as they currently are exact, but maybe too long or not friendly enough, or confusing maybe? On top of that I'm not sure about the procedure for addons.

👍 1

tobiasd commented

2018-04-01 11:16:25 +02:00

(Migrated from github.com)

In the addon directory you want to extract the strings /path/to/run_xgettext.sh -s

In the addon directory you want to extract the strings `/path/to/run_xgettext.sh -s`

MrPetovan commented

2018-04-01 17:17:49 +02:00

(Migrated from github.com)

I accidentally ran /path/to/run_xgettext.sh -s in the literal /path/to/friendica/addon folder, and I found an empty translation string that triggered a notice in gettext!

I accidentally ran `/path/to/run_xgettext.sh -s` in the literal `/path/to/friendica/addon` folder, and I found an empty translation string that triggered a notice in gettext!

tobiasd (Migrated from github.com) reviewed 2018-04-02 19:01:24 +02:00

tobiasd (Migrated from github.com) approved these changes 2018-04-02 19:02:36 +02:00