Results are now cached, format limits to other networks are respected #553

Merged

annando merged 2 commits from osm-cache into 3.6-rc

2018-03-20 08:48:02 +01:00

annando commented

2018-03-20 07:48:01 +01:00

(Migrated from github.com)

This belongs to PR https://github.com/friendica/friendica/pull/4636

Additionally to the improvements for exports to other networks, there is now a caching of requests to avoid restrictions by the OSM servers.

This belongs to PR https://github.com/friendica/friendica/pull/4636 Additionally to the improvements for exports to other networks, there is now a caching of requests to avoid restrictions by the OSM servers.

tobiasd (Migrated from github.com) reviewed 2018-03-20 07:52:19 +01:00

tobiasd (Migrated from github.com) reviewed 2018-03-20 07:53:43 +01:00

annando (Migrated from github.com) reviewed 2018-03-20 07:56:25 +01:00

tobiasd (Migrated from github.com) reviewed 2018-03-20 07:57:41 +01:00

tobiasd commented

2018-03-20 08:10:11 +01:00

(Migrated from github.com)

Should these changes be applied to the googlemaps addpn as well?

annando commented

2018-03-20 08:30:12 +01:00

(Migrated from github.com)

I hadn't realized that we are having one ;-)

~~Yeah, I can submit an additional PR for that. But this is not blocking for this PR or the core PR.~~

Edit: The "googlemaps" addon doesn't return an inline frame. So it isn't blocking for the original issue. And there is no functionality to return geo coordinates from a given location. I guess that you need some API access for that.

So: No, I won't submit one PR for that.

I hadn't realized that we are having one ;-) ~Yeah, I can submit an additional PR for that. But this is not blocking for this PR or the core PR.~ Edit: The "googlemaps" addon doesn't return an inline frame. So it isn't blocking for the original issue. And there is no functionality to return geo coordinates from a given location. I guess that you need some API access for that. So: No, I won't submit one PR for that.

tobiasd commented

2018-03-20 08:46:50 +01:00

(Migrated from github.com)

Ok, thanks for checking :-)