friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 4 Releases 16 Wiki Activity

[communityhome] Remove active users feature #539

Merged
MrPetovan merged 4 commits from bug/4555-remove-active-users-feature into 3.6-rc 2018-03-08 14:19:46 +01:00
Conversation 11 Commits 4 Files Changed 3 +74 -129
MrPetovan commented 2018-03-07 20:13:40 +01:00 (Migrated from github.com)
Copy Link

Closes https://github.com/friendica/friendica/issues/4555

Closes https://github.com/friendica/friendica/issues/4555
annando commented 2018-03-07 20:49:08 +01:00 (Migrated from github.com)
Copy Link

Most of the queries in this addon are extremely intense. I suggest rebuilding that addon so that it only shows the community page, not more.

Most of the queries in this addon are extremely intense. I suggest rebuilding that addon so that it only shows the community page, not more.
MrPetovan commented 2018-03-07 21:15:55 +01:00 (Migrated from github.com)
Copy Link

Sure, but not for the 3.6 release though.

Sure, but not for the 3.6 release though.
annando commented 2018-03-07 21:49:48 +01:00 (Migrated from github.com)
Copy Link

I'm unsure. Problem is that the two queries with the likes and the photos are so intense, that they kill every server that is a little bit larger. So it only works on small servers with few users. But there this addon doesn't make sense.

I'm unsure. Problem is that the two queries with the likes and the photos are so intense, that they kill every server that is a little bit larger. So it only works on small servers with few users. But there this addon doesn't make sense.
MrPetovan commented 2018-03-07 21:58:56 +01:00 (Migrated from github.com)
Copy Link

We can retire the addon altogether as well.

We can retire the addon altogether as well.
annando commented 2018-03-08 07:53:05 +01:00 (Migrated from github.com)
Copy Link

Possibly this would be the best. But we should not only set the special comment in the header, but also we should disable the functionality as well.

Possibly this would be the best. But we should not only set the special comment in the header, but also we should disable the functionality as well.
MrPetovan commented 2018-03-08 10:43:31 +01:00 (Migrated from github.com)
Copy Link

So we keep this PR and I just add the deprecated header?

So we keep this PR and I just add the deprecated header?
annando commented 2018-03-08 11:21:39 +01:00 (Migrated from github.com)
Copy Link

I would prefer adding some return to the beginning of the functions. This can be done in this PR.

I would prefer adding some ```return``` to the beginning of the functions. This can be done in this PR.
MrPetovan commented 2018-03-08 13:14:15 +01:00 (Migrated from github.com)
Copy Link

I don't see the point, if node admins want to try the addon, they can, and if it's too slow, they can deactivate it. I removed a feature whose query was triggering an error, but the rest is fine, even if it's slow.

I don't see the point, if node admins want to try the addon, they can, and if it's too slow, they can deactivate it. I removed a feature whose query was triggering an error, but the rest is fine, even if it's slow.
annando commented 2018-03-08 14:14:56 +01:00 (Migrated from github.com)
Copy Link

I see the problem that people try it when their server is small enough for it. But it will be slower and slower. And since many regular users won't see the front page, they won't recognize the loss of speed.

I also guess that (possibly due to changed indexes?) the queries in that addon will massively slow down the system.

When - eventually - I will do the new stuff with the item table, I will massively remove functionality in that addon anyway :-)

I see the problem that people try it when their server is small enough for it. But it will be slower and slower. And since many regular users won't see the front page, they won't recognize the loss of speed. I also guess that (possibly due to changed indexes?) the queries in that addon will massively slow down the system. When - eventually - I will do the new stuff with the item table, I will massively remove functionality in that addon anyway :-)
MrPetovan commented 2018-03-08 14:16:53 +01:00 (Migrated from github.com)
Copy Link

But since it's now unsupported, most node admins won't be able to enable it anyway.

But since it's now unsupported, most node admins won't be able to enable it anyway.
annando commented 2018-03-08 14:18:50 +01:00 (Migrated from github.com)
Copy Link

Okay, let's see what will happen.

Okay, let's see what will happen.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#539
No description provided.
Delete Branch "bug/4555-remove-active-users-feature"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?