[communityhome] Remove active users feature

MrPetovan commented

2018-03-07 20:13:40 +01:00

(Migrated from github.com)

Closes https://github.com/friendica/friendica/issues/4555

annando commented

2018-03-07 20:49:08 +01:00

(Migrated from github.com)

Most of the queries in this addon are extremely intense. I suggest rebuilding that addon so that it only shows the community page, not more.

MrPetovan commented

2018-03-07 21:15:55 +01:00

(Migrated from github.com)

Sure, but not for the 3.6 release though.

annando commented

2018-03-07 21:49:48 +01:00

(Migrated from github.com)

I'm unsure. Problem is that the two queries with the likes and the photos are so intense, that they kill every server that is a little bit larger. So it only works on small servers with few users. But there this addon doesn't make sense.

MrPetovan commented

2018-03-07 21:58:56 +01:00

(Migrated from github.com)

We can retire the addon altogether as well.

annando commented

2018-03-08 07:53:05 +01:00

(Migrated from github.com)

Possibly this would be the best. But we should not only set the special comment in the header, but also we should disable the functionality as well.

MrPetovan commented

2018-03-08 10:43:31 +01:00

(Migrated from github.com)

So we keep this PR and I just add the deprecated header?

annando commented

2018-03-08 11:21:39 +01:00

(Migrated from github.com)

I would prefer adding some return to the beginning of the functions. This can be done in this PR.

I would prefer adding some ```return``` to the beginning of the functions. This can be done in this PR.

MrPetovan commented

2018-03-08 13:14:15 +01:00

(Migrated from github.com)

I don't see the point, if node admins want to try the addon, they can, and if it's too slow, they can deactivate it. I removed a feature whose query was triggering an error, but the rest is fine, even if it's slow.

annando commented

2018-03-08 14:14:56 +01:00

(Migrated from github.com)

I see the problem that people try it when their server is small enough for it. But it will be slower and slower. And since many regular users won't see the front page, they won't recognize the loss of speed.

I also guess that (possibly due to changed indexes?) the queries in that addon will massively slow down the system.

When - eventually - I will do the new stuff with the item table, I will massively remove functionality in that addon anyway :-)

I see the problem that people try it when their server is small enough for it. But it will be slower and slower. And since many regular users won't see the front page, they won't recognize the loss of speed. I also guess that (possibly due to changed indexes?) the queries in that addon will massively slow down the system. When - eventually - I will do the new stuff with the item table, I will massively remove functionality in that addon anyway :-)

MrPetovan commented

2018-03-08 14:16:53 +01:00

(Migrated from github.com)

But since it's now unsupported, most node admins won't be able to enable it anyway.

annando commented

2018-03-08 14:18:50 +01:00

(Migrated from github.com)

Okay, let's see what will happen.

[communityhome] Remove active users feature #539