followup on #498 #500

Merged

tobiasd merged 1 commits from 20180124-nsfwde3 into develop

2018-01-24 17:32:20 +01:00

tobiasd commented

2018-01-24 17:26:36 +01:00

(Migrated from github.com)

Now using addon instead of plugin as Transifix has picked up the
renewed source files.

Now using addon instead of plugin as Transifix has picked up the renewed source files.

zeroadam (Migrated from github.com) approved these changes 2018-01-24 17:28:10 +01:00

MrPetovan commented

2018-01-24 17:30:40 +01:00

(Migrated from github.com)

How does Transifex pick up the strings to translate? Do we need to update the search pattern over there as well after the move to L10n::t(t)?

How does Transifex pick up the strings to translate? Do we need to update the search pattern over there as well after the move to `L10n::t(t)`?

MrPetovan (Migrated from github.com) approved these changes 2018-01-24 17:31:15 +01:00

tobiasd commented

2018-01-24 17:39:59 +01:00

(Migrated from github.com)

Transifex loads the messages.po files from github. Thats why I asked for the files produced by the export function. They should not be different from the contents, the order may change,

Transifex works only with the contents of the messages.po files. That is why whenever the strings int the PHP files are changed one should also run the extraction script and update the messages.po files of the addon or core changed. As those who change the strings often do not run the extraction script, there is a gap between the dataset in the PHP files, the messages.po files and the strings at Transifex which is the base translators work with.

Transifex loads the `messages.po` files from github. Thats why I asked for the files produced by the export function. They should not be different from the contents, the order may change, Transifex works only with the contents of the `messages.po` files. That is why whenever the strings int the PHP files are changed one should also run the extraction script and update the `messages.po` files of the addon or core changed. As those who change the strings often do not run the extraction script, there is a gap between the dataset in the PHP files, the `messages.po` files and the strings at Transifex which is the base translators work with.

MrPetovan commented

2018-01-24 17:42:50 +01:00

(Migrated from github.com)

Thanks for the explanation.