Use Exceptions for User::create

MrPetovan commented

2017-12-13 03:18:59 +01:00

(Migrated from github.com)

Follows https://github.com/friendica/friendica/pull/4054.

Follows https://github.com/friendica/friendica/pull/4054. Related to https://github.com/friendica/friendica/issues/4041

annando commented

2017-12-13 11:05:37 +01:00

(Migrated from github.com)

The corresponding PR is not yet merged due to an open question. I suggest that we assume that no one who is using this addon does update the system in the meantime ;-)

tobiasd commented

2017-12-13 12:14:22 +01:00

(Migrated from github.com)

No, just revert it and reapply the PR, who know how long the other one is blocked in a non-blocked state.

Also please make the dependency clearer the next time.

No, just revert it and reapply the PR, who know how long the other one is blocked in a non-blocked state. Also please make the dependency clearer the next time.

MrPetovan commented

2017-12-13 14:06:54 +01:00

(Migrated from github.com)

Please advise on how much more clear I can be than "Follows friendica/friendica#4054.".

annando commented

2017-12-13 14:47:02 +01:00

(Migrated from github.com)

You could write "depends upon PR #..."

zeroadam commented

2017-12-13 14:58:20 +01:00

(Migrated from github.com)

Blocked by PR #...

On Wed, Dec 13, 2017, 08:47 Michael Vogel notifications@github.com wrote:

You could write "depends upon PR #..."

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/friendica/friendica-addons/pull/475#issuecomment-351395495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFyWzPlTPVujt5V6aGbptCHabeDJtC8lks5s_9VXgaJpZM4Q_6iB
.

Blocked by PR #... On Wed, Dec 13, 2017, 08:47 Michael Vogel <notifications@github.com> wrote: > You could write "depends upon PR #..." > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/friendica/friendica-addons/pull/475#issuecomment-351395495>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AFyWzPlTPVujt5V6aGbptCHabeDJtC8lks5s_9VXgaJpZM4Q_6iB> > . >

MrPetovan commented

2017-12-13 16:33:41 +01:00

(Migrated from github.com)

Gotcha, I will use this language next time.

tobiasd commented

2017-12-13 16:47:47 +01:00

(Migrated from github.com)

Yes, something like that. For me it read "follows the same directio/spiritn as the other PR was" which had a note of "I'm not merging it only because of the LEFT JOIN". This one did not have it and adding the exceptions made sense. Hence my false/confused merging this one.

When the other PR is merged. Reverting the revert should make this PR live again right?

Yes, something like that. For me it read "follows the same directio/spiritn as the other PR was" which had a note of "I'm not merging it only because of the LEFT JOIN". This one did not have it and adding the exceptions made sense. Hence my false/confused merging this one. When the other PR is merged. Reverting the revert should make this PR live again right?

MrPetovan commented

2017-12-13 17:04:11 +01:00

(Migrated from github.com)

Yes!

Use Exceptions for User::create #475