friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 2 Releases 16 Wiki Activity

Grouping parentheses instead of capturing parentheses #443

Merged
rebeka-catalina merged 3 commits from rct/d/NSFW_README_examples into master 2017-11-08 17:45:26 +01:00
Conversation 3 Commits 3 Files Changed 1 +19 -1
rebeka-catalina commented 2017-11-08 16:24:57 +01:00 (Migrated from github.com)
Copy Link

As already mentioned in the README file, the usage of of capturing parathese produces errors, so it's important to use grouping parantheses there instead.

As already mentioned in the README file, the usage of of capturing parathese produces errors, so it's important to use grouping parantheses there instead.
zeroadam (Migrated from github.com) approved these changes 2017-11-08 16:37:33 +01:00
zeroadam (Migrated from github.com) left a comment
Copy Link

I had to use a regex tester to see this is action, but I see exactly what you're saying!

I had to use a regex tester to see this is action, but I see exactly what you're saying!
MrPetovan (Migrated from github.com) requested changes 2017-11-08 16:50:25 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy Link

Typos: It is "parentheses", not "parantheses".

Typos: It is "parentheses", not "parantheses".
MrPetovan (Migrated from github.com) reviewed 2017-11-08 16:51:34 +01:00
rebeka-catalina commented 2017-11-08 17:18:04 +01:00 (Migrated from github.com)
Copy Link

Yes, you're right.

On 2017.11.08, Hypolite Petovan wrote:

MrPetovan commented on this pull request.

@@ -47,7 +47,25 @@ done with a single regex, which matches all of them:
Another use case could be, that you are simply not
interested in postings about christmas.

  • /christmas([-_ ]?(tree|time|eve|pudding))?/
  • /christmas([-_ ]?(?:tree|time|eve|pudding))?/

What about the first set of parentheses, shouldn't they be grouping as well?

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75145717

Yes, you're right. On 2017.11.08, Hypolite Petovan wrote: > MrPetovan commented on this pull request. > > > > > @@ -47,7 +47,25 @@ done with a single regex, which matches all of them: > Another use case could be, that you are simply not > interested in postings about christmas. > > - /christmas([-_ ]?(tree|time|eve|pudding))?/ > + /christmas([-_ ]?(?:tree|time|eve|pudding))?/ > > What about the first set of parentheses, shouldn't they be grouping as well? > > -- > You are receiving this because you authored the thread. > Reply to this email directly or view it on GitHub: > https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75145717
MrPetovan (Migrated from github.com) requested changes 2017-11-08 17:34:41 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy Link

You still have to fix the typos 😛

You still have to fix the typos 😛
MrPetovan (Migrated from github.com) approved these changes 2017-11-08 17:45:07 +01:00
rebeka-catalina commented 2017-11-08 17:46:09 +01:00 (Migrated from github.com)
Copy Link

This is not my day -.-
Sorry

On 2017.11.08, Hypolite Petovan wrote:

MrPetovan requested changes on this pull request.

You still have to fix the typos 😛

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75162512

This is not my day -.- Sorry On 2017.11.08, Hypolite Petovan wrote: > MrPetovan requested changes on this pull request. > > You still have to fix the typos 😛 > > > > -- > You are receiving this because you authored the thread. > Reply to this email directly or view it on GitHub: > https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75162512
tobiasd commented 2017-11-08 18:38:11 +01:00 (Migrated from github.com)
Copy Link

This is not my day -.-

Why, it is just gamification of useless commit statistics ;-)

> This is not my day -.- Why, it is just gamification of useless commit statistics ;-)
Sign in to join this conversation.
Reviewers
No reviewers
zeroadam
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#443
No description provided.
Delete Branch "rct/d/NSFW_README_examples"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?