Grouping parentheses instead of capturing parentheses #443

Merged

rebeka-catalina merged 3 commits from rct/d/NSFW_README_examples into master

2017-11-08 17:45:26 +01:00

rebeka-catalina commented

2017-11-08 16:24:57 +01:00

(Migrated from github.com)

As already mentioned in the README file, the usage of of capturing parathese produces errors, so it's important to use grouping parantheses there instead.

zeroadam (Migrated from github.com) approved these changes 2017-11-08 16:37:33 +01:00

zeroadam (Migrated from github.com) left a comment

I had to use a regex tester to see this is action, but I see exactly what you're saying!

MrPetovan (Migrated from github.com) requested changes 2017-11-08 16:50:25 +01:00

MrPetovan (Migrated from github.com) left a comment

Typos: It is "parentheses", not "parantheses".

MrPetovan (Migrated from github.com) reviewed 2017-11-08 16:51:34 +01:00

rebeka-catalina commented

2017-11-08 17:18:04 +01:00

(Migrated from github.com)

Yes, you're right.

On 2017.11.08, Hypolite Petovan wrote:

MrPetovan commented on this pull request.

@@ -47,7 +47,25 @@ done with a single regex, which matches all of them:
Another use case could be, that you are simply not
interested in postings about christmas.

/christmas([-_ ]?(tree|time|eve|pudding))?/

/christmas([-_ ]?(?:tree|time|eve|pudding))?/

What about the first set of parentheses, shouldn't they be grouping as well?

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75145717

Yes, you're right. On 2017.11.08, Hypolite Petovan wrote: > MrPetovan commented on this pull request. > > > > > @@ -47,7 +47,25 @@ done with a single regex, which matches all of them: > Another use case could be, that you are simply not > interested in postings about christmas. > > - /christmas([-_ ]?(tree|time|eve|pudding))?/ > + /christmas([-_ ]?(?:tree|time|eve|pudding))?/ > > What about the first set of parentheses, shouldn't they be grouping as well? > > -- > You are receiving this because you authored the thread. > Reply to this email directly or view it on GitHub: > https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75145717

MrPetovan (Migrated from github.com) requested changes 2017-11-08 17:34:41 +01:00

MrPetovan (Migrated from github.com) left a comment

You still have to fix the typos 😛

MrPetovan (Migrated from github.com) approved these changes 2017-11-08 17:45:07 +01:00

rebeka-catalina commented

2017-11-08 17:46:09 +01:00

(Migrated from github.com)

This is not my day -.-
Sorry

On 2017.11.08, Hypolite Petovan wrote:

MrPetovan requested changes on this pull request.

You still have to fix the typos 😛

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75162512

This is not my day -.- Sorry On 2017.11.08, Hypolite Petovan wrote: > MrPetovan requested changes on this pull request. > > You still have to fix the typos 😛 > > > > -- > You are receiving this because you authored the thread. > Reply to this email directly or view it on GitHub: > https://github.com/friendica/friendica-addons/pull/443#pullrequestreview-75162512

tobiasd commented

2017-11-08 18:38:11 +01:00

(Migrated from github.com)