Remove reference to library/langdet folder #428

Merged

MrPetovan merged 1 commit from task/update-languagedetect into master

2017-10-05 10:49:47 +02:00

MrPetovan commented

2017-09-28 05:19:10 +02:00

(Migrated from github.com)

This PR should ony be approved after this one: https://github.com/friendica/friendica/pull/3743

annando commented

2017-09-28 06:17:42 +02:00

(Migrated from github.com)

Could you change the "require_once" to an "include_once"? Then this change should work on both, "master" and "develop" branch.

MrPetovan commented

2017-09-29 04:21:40 +02:00

(Migrated from github.com)

I'd rather not, it would emit a warning in the logs each time the plugin is loaded if the library isn't in library anymore, which is the goal since we don't maintain multiple versions branch of Friendica at once.

I'd rather not, it would emit a warning in the logs each time the plugin is loaded if the library isn't in `library` anymore, which is the goal since we don't maintain multiple versions branch of Friendica at once.

annando commented

2017-09-29 23:14:27 +02:00

(Migrated from github.com)

So what do we do?

MrPetovan commented

2017-09-29 23:18:06 +02:00

(Migrated from github.com)

I seem to remember we already had a breaking change between the library folder and the vendor folder affecting addons, how did we do the first time?

Otherwise we release a new version of the addon repo along the next Friendica version the library change is present.

I seem to remember we already had a breaking change between the library folder and the vendor folder affecting addons, how did we do the first time? Otherwise we release a new version of the addon repo along the next Friendica version the library change is present.

tobiasd commented

2017-09-30 11:34:37 +02:00

(Migrated from github.com)

We tag the addon repo (now again) so after the release, who runs too fresh addons should also update the main repo.

annando commented

2017-10-05 11:32:12 +02:00

(Migrated from github.com)

Merging this is a problem. The addon won't work with the master branch anymore from now on.

tobiasd commented

2017-10-05 12:47:55 +02:00

(Migrated from github.com)

On Thu, 05 Oct 2017 09:32:13 +0000 (UTC)
Michael Vogel notifications@github.com wrote:

Merging this is a problem. The addon won't work with the master
branch anymore from now on.

The 3.5.3 version of the addons was tagged before the PR was merged. You should checkout the 3.5.3 versions of the addons if you want to use version 3.5.3 core (master).

But my solution for the langdetect problems would be reverting both of the PRs.

--
Web ............ www.diekershoff.net
~friendica ..... tobias@social.diekershoff.de
PGP-ID ......... 0x25FE376FF17694A1

On Thu, 05 Oct 2017 09:32:13 +0000 (UTC) Michael Vogel <notifications@github.com> wrote: > Merging this is a problem. The addon won't work with the master > branch anymore from now on. The 3.5.3 version of the addons was tagged before the PR was merged. You should checkout the 3.5.3 versions of the addons if you want to use version 3.5.3 core (master). But my solution for the langdetect problems would be reverting both of the PRs. -- Web ............ www.diekershoff.net ~friendica ..... tobias@social.diekershoff.de PGP-ID ......... 0x25FE376FF17694A1