Secure Mail 2.0 #410

Merged

fabrixxm merged 4 commits from securemail-2.0 into master

2017-04-14 17:33:28 +02:00

fabrixxm commented

2017-04-11 21:25:18 +02:00

(Migrated from github.com)

Remove php-gpg, add openpgp-php and phpseclib.
Add template file for settings.
Add "send test" functionality.
Add messages.po

Remove php-gpg, add openpgp-php and phpseclib. Add template file for settings. Add "send test" functionality. Add messages.po

MrPetovan (Migrated from github.com) reviewed 2017-04-11 21:40:44 +02:00

MrPetovan (Migrated from github.com) left a comment

Wikimedia actually has a system to manage optional dependencies through Composer: https://github.com/wikimedia/composer-merge-plugin

Of course this would mean each Add-on would be a composer-enabled library as well, which I'm not sure how difficult it would be to convert.

In the mean time I think all dependencies should be grouped into the main composer.json.

Alright, we have to decide something regarding library autoloading from the add-ons. I'm in favor of putting any library needed by any addon in Friendica's Composer. After all, add-ons are part of Friendica since the same team is maintaining both projects. Wikimedia actually has a system to manage optional dependencies through Composer: https://github.com/wikimedia/composer-merge-plugin Of course this would mean each Add-on would be a composer-enabled library as well, which I'm not sure how difficult it would be to convert. In the mean time I think all dependencies should be grouped into the main composer.json.

tobiasd commented

2017-04-12 07:13:34 +02:00

(Migrated from github.com)

What with independent addons - not every addon for Friendica is also part of this repository - put their dependencies into Friendica core as well? I think addons should care about their own dependencies. They are separate works building onto the platform, not necessarily part of the platform.

MrPetovan commented

2017-04-12 16:42:48 +02:00

(Migrated from github.com)

The potential issue with independent addons is exactly what the Composer Merge Plugin is about: by scanning the addon folder for composer.json files, it ensures that the base vendor directory and the autoload.php are populated with any library required by any addon.

The potential issue with independent addons is exactly what the Composer Merge Plugin is about: by scanning the addon folder for `composer.json` files, it ensures that the base `vendor` directory and the `autoload.php` are populated with any library required by any addon.

fabrixxm commented

2017-04-12 17:15:28 +02:00

(Migrated from github.com)

I was thinking something like that plugin , but I have to draft better how make it work..

back to the PR, any comments?
Note that I used "vendor" dir because I installed the libraries with composer, but then I remove everything not strictly required, composer-related files also, as I'm including them directly..
Note also that the only code I wrote is in securemail/securemail.php (and most of the openpgp-php usage is.. inspired by a wordpress plugin...)

I was thinking something like that plugin , but I have to draft better how make it work.. back to the PR, any comments? Note that I used "vendor" dir because I installed the libraries with composer, but then I remove everything not strictly required, composer-related files also, as I'm including them directly.. Note also that the only code I wrote is in securemail/securemail.php (and most of the openpgp-php usage is.. inspired by a wordpress plugin...)

MrPetovan commented

2017-04-12 17:19:21 +02:00

(Migrated from github.com)

Aside from that janky library inclusion, the plugin seemed fine to me. I'd still really prefer the library to be available in the main Friendica repository for non-independent addons.

MrPetovan (Migrated from github.com) requested changes 2017-04-12 17:31:22 +02:00

MrPetovan (Migrated from github.com) left a comment

Only standards changes requested.

fabrixxm (Migrated from github.com) reviewed 2017-04-14 08:41:09 +02:00

fabrixxm (Migrated from github.com) reviewed 2017-04-14 08:44:55 +02:00

MrPetovan (Migrated from github.com) requested changes 2017-04-14 15:48:25 +02:00

MrPetovan (Migrated from github.com) left a comment

Thanks for the standards work! There are a few minor touchups, one Parse Error with PHP5, a few new line characters becoming literal after quote style changes.

MrPetovan (Migrated from github.com) approved these changes 2017-04-14 17:32:17 +02:00