Cleanup implementation of langfilter_prepare_body, and fix a typo #307

Merged

strk merged 4 commits from langfilter-cleanersplit into master

2015-09-22 16:08:05 +02:00

strk commented

2015-09-22 12:31:52 +02:00

(Migrated from github.com)

I'd actually want to add a new setting to restrict filtering to posts for which the language guessers has a minimum confidence

strk commented

2015-09-22 13:07:54 +02:00

(Migrated from github.com)

Minimum confidence in language detection support added. @tobiasd let me know if you prefer a squash-rebase of all of this.

tobiasd commented

2015-09-22 14:52:33 +02:00

(Migrated from github.com)

As you have introduced new strings for the translation, could you run

../../util/run_xgettext.sh -s

in the langfilter directory (assuming that is $friendica/addon/langfilter) to regenerate the addons messages.po file and include it to the PR?

I have only scratched together the initial version of the addon, but I'm not using it myself. So feel free to enhance it as you feel appropriate :-)

As you have introduced new strings for the translation, could you run ``` ../../util/run_xgettext.sh -s ``` in the langfilter directory (assuming that is $friendica/addon/langfilter) to regenerate the addons messages.po file and include it to the PR? I have only scratched together the initial version of the addon, but I'm not using it myself. So feel free to enhance it as you feel appropriate :-)

strk commented

2015-09-22 15:20:11 +02:00

(Migrated from github.com)

Translation file change pushed.
How much does it take for it to get to transifex ?

About enhancements... if you give me write access I can avoid
bothering you on next one.

Translation file change pushed. How much does it take for it to get to transifex ? About enhancements... if you give me write access I can avoid bothering you on next one.

tobiasd commented

2015-09-22 16:07:31 +02:00

(Migrated from github.com)

It usually takes 24h till the automatic update on the transifex side.

Direct writing is bad, there should be someone else to at least look over the code ;-) PRs don't really bother me. It's more that I don't develop this addon actively. So you can enhance it in ways you seem fitting.

It usually takes 24h till the automatic update on the transifex side. Direct writing is bad, there should be someone else to at least look over the code ;-) PRs don't really bother me. It's more that I don't develop this addon actively. So you can enhance it in ways you seem fitting.