friendica/friendica-addons
9
4
Fork 16
Code Issues 3 Pull requests 4 Releases 16 Wiki Activity

PHPStan level 3 #1603

Merged
nupplaPhil merged 15 commits from Art4/friendica-addons:phpstan-level-3 into develop 2025-04-27 02:17:42 +02:00
Conversation 1 Commits 15 Files changed 13 +47 -40
Art4 commented 2025-02-25 16:29:38 +01:00
Contributor
Copy link

This PR fixes all 22 errors that are reported by PHPStan level 3.

This PR targets the 2025.05 release.

Refs https://github.com/friendica/friendica/pull/14830

This PR fixes all 22 errors that are reported by PHPStan level 3. This PR targets the 2025.05 release. Refs https://github.com/friendica/friendica/pull/14830
Art4 stopped working 2025-02-25 16:29:54 +01:00
5 seconds
Art4 deleted spent time 2025-02-25 16:30:15 +01:00
- 5 seconds
Art4 changed title from WIP: PHPStan level 3 to PHPStan level 3 2025-03-13 12:58:57 +01:00
MrPetovan requested changes 2025-03-13 16:08:01 +01:00
bluesky/bluesky.php Outdated
@ -962,3 +962,3 @@
$comments = Post::countPosts(['thr-parent' => $existing_uri, 'gravity' => Item::GRAVITY_COMMENT]);
if (($post->replyCount <= $comments) || !$complete) {
return DI::atpProcessor()->fetchUriId($existing_uri, $uid);
return (int) DI::atpProcessor()->fetchUriId($existing_uri, $uid);
MrPetovan commented 2025-03-13 15:57:19 +01:00
Owner
Copy link

Please change \Friendica\Protocol\ATProtocol\Processor::fetchUriId to always return an integer. This is what the method is expected to do.

Please change `\Friendica\Protocol\ATProtocol\Processor::fetchUriId` to always return an integer. This is what the method is expected to do.
👍 1
Art4 commented 2025-03-14 08:52:36 +01:00
Author
Contributor
Copy link

Done with https://github.com/friendica/friendica/pull/14830/commits/8ba652818f169a4391c193f9dde31c3c0dddb61e and removed the type casting with db875bc755

Done with https://github.com/friendica/friendica/pull/14830/commits/8ba652818f169a4391c193f9dde31c3c0dddb61e and removed the type casting with https://git.friendi.ca/friendica/friendica-addons/commit/db875bc755449ec71571a35cb62942b282cae0b9
Art4 marked this conversation as resolved
libravatar/Services/Libravatar.php Outdated
@ -369,3 +369,3 @@
if (filter_var($identifier, FILTER_VALIDATE_EMAIL)) {
$email = explode('@', $identifier);
return $email[1];
return (string) $email[1];
MrPetovan commented 2025-03-13 15:59:40 +01:00
Owner
Copy link

I'm surprised by this, explode() reportedly only returns strings in the output array. What case is this meant to address?

I'm surprised by this, `explode()` reportedly only returns strings in the output array. What case is this meant to address?
Art4 commented 2025-03-14 09:14:39 +01:00
Author
Contributor
Copy link

I was surprised too, but thought PHPStan complains because explode() could also return false. But now I removed the type cast and PHPStan don't show an error anymore. 🤷

I was surprised too, but thought PHPStan complains because `explode()` could also return `false`. But now I removed the type cast and PHPStan don't show an error anymore. 🤷
Art4 marked this conversation as resolved
libravatar/Services/Libravatar.php Outdated
@ -374,3 +374,3 @@
//OpenID
$url = parse_url($identifier);
$domain = $url['host'];
$domain = (string) $url['host'];
MrPetovan commented 2025-03-13 16:00:29 +01:00
Owner
Copy link

parse_url() only returns an integer for the port key, this is superfluous.

`parse_url()` only returns an integer for the `port` key, this is superfluous.
Art4 commented 2025-03-14 09:15:24 +01:00
Author
Contributor
Copy link

Same as above: #1603 (comment)

Same as above: https://git.friendi.ca/friendica/friendica-addons/pulls/1603#issuecomment-196305
Art4 marked this conversation as resolved
notifyall/notifyall.php Outdated
@ -51,3 +51,3 @@
$recipients = DBA::p("SELECT DISTINCT `email` FROM `user`" . DBA::buildCondition($condition), $condition);
if (! $recipients) {
if (! $recipients || !is_iterable($recipients)) {
MrPetovan commented 2025-03-13 16:04:40 +01:00
Owner
Copy link

Instead of checking for this, $recipients should be assigned the result of DBA::toArray(DBA:p(...)) in order for the later foreach() to be valid. Normally, the DBA::p output requires the use of DBA::fetch() in a loop.

Sure, the PDOStatement is iterable, but the mysqli-produced result resource probably isn't.

Instead of checking for this, `$recipients` should be assigned the result of `DBA::toArray(DBA:p(...))` in order for the later `foreach()` to be valid. Normally, the `DBA::p` output requires the use of `DBA::fetch()` in a loop. Sure, the `PDOStatement` is iterable, but the `mysqli`-produced result resource probably isn't.
👍 1
Art4 commented 2025-03-14 09:22:00 +01:00
Author
Contributor
Copy link

Done, thank you.

Done, thank you.
Art4 marked this conversation as resolved
requested review from MrPetovan 2025-03-14 09:22:10 +01:00
nupplaPhil merged commit 95a9f7038a into develop 2025-04-27 02:17:42 +02:00
Art4 deleted branch phpstan-level-3 2025-04-28 15:22:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
2024.09

   
2024.12

   
2025.02

   
2025.05

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
2024.09
2024.12
2025.02
2025.05
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1603
No description provided.
Delete branch "Art4/friendica-addons:phpstan-level-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?