CLD: New plugin for language detection via CLD2 #1425

heluecht · 2023-10-01T09:10:47+02:00

heluecht commented

2023-10-01 09:10:47 +02:00

The CLD2 detection is superior to our used detection, but it is not really easy to install. So it is added as an addon.

heluecht added 3 commits 2023-10-01 09:10:48 +02:00

CLD: New plugin for language detection via CLD2 1ab765cba9

Cleaned up code cd3adace83

Renamed hook 299fffd7b1

heluecht changed title from ~~CLD: New plugin for language detection via CLD2 #1423~~ to CLD: New plugin for language detection via CLD2

2023-10-01 15:57:57 +02:00

MrPetovan requested changes 2023-10-03 03:51:53 +02:00

cld/README.md Outdated

					
				@ -0,0 +62,4 @@

				cd /etc/php/8.0/mods-available

				```

				Create the file `cld.ini` with this content:

MrPetovan commented

2023-10-03 03:48:50 +02:00

This file should be called cld2.ini as it's the name of the module. This also enables phpenmod cld2 on Debian-based distributions.

This file should be called `cld2.ini` as it's the name of the module. This also enables `phpenmod cld2` on Debian-based distributions.

heluecht commented

2023-10-06 06:14:59 +02:00

Done

cld/README.md Outdated

					
				@ -0,0 +69,4 @@

				extension=cld2.so

				```

				Change to the folder `conf.d` in the folder of your `php.ini`.

MrPetovan commented

2023-10-03 03:42:54 +02:00

On Debian-based distributions, this can be replaced by running phpenmod cld2.

On Debian-based distributions, this can be replaced by running `phpenmod cld2`.

heluecht commented

2023-10-03 04:42:39 +02:00

done

cld/cld.php Outdated

					
				@ -0,0 +12,4 @@

				function cld_install()

				{

					Hook::register('detect_languages', 'addon/cld/cld.php', 'cld_detect_languages');

MrPetovan commented

2023-10-03 03:49:28 +02:00

Please avoid hardcoded file paths when you can.

	Hook::register('detect_languages', __FILE__, 'cld_detect_languages');

Please avoid hardcoded file paths when you can. ```php Hook::register('detect_languages', __FILE__, 'cld_detect_languages'); ```

heluecht commented

2023-10-07 06:41:57 +02:00

Done

cld/cld.php Outdated

					
				@ -0,0 +64,4 @@

					}

					Logger::debug('Detected different language', ['original' => $original, 'detected' => $detected, 'name' => $result['language_name'], 'probability' => $result['language_probability'], 'text' => $data['text']]);

					$data['detected'] = [$detected => $result['language_probability'] / 100];

MrPetovan commented

2023-10-03 03:51:49 +02:00

I thought the detected key was only a list of language codes. Please mention in the documentation of the hook detect_languages that it's an associative array with the language code as the keys and the language probability as the values.

I thought the `detected` key was only a list of language codes. Please mention in the documentation of the hook `detect_languages` that it's an associative array with the language code as the keys and the language probability as the values.