friendica/friendica-addons
7
2
Fork 14
Code Issues 3 Pull requests 3 Releases 16 Wiki Activity

[various] Remove morechoice and morepokes addons #1278

Merged
MrPetovan merged 2 commits from task/remove-poke into develop 2022-08-11 18:17:20 +02:00
Conversation 3 Commits 2 Files changed 60 -8346
MrPetovan commented 2022-08-09 21:06:24 +02:00 (Migrated from github.com)
Copy link

Depends on https://github.com/friendica/friendica/pull/11837

The morechoice addon was also meant to be removed alongside the gender, sex and marital status profile fields.

Depends on https://github.com/friendica/friendica/pull/11837 The morechoice addon was also meant to be removed alongside the gender, sex and marital status profile fields.
👍 2
tobiasd commented 2022-08-10 06:55:28 +02:00 (Migrated from github.com)
Copy link

So far we had deprecated an addon before it was removed after a grace period. Given the functionality of these addons, I think we can ditch the grace period this time.

However, can you please add the addons to the deprecated-addons repository.

So far we had deprecated an addon before it was removed after a grace period. Given the functionality of these addons, I think we can ditch the grace period this time. However, can you please add the addons to the deprecated-addons repository.
MrPetovan commented 2022-08-10 07:52:11 +02:00 (Migrated from github.com)
Copy link

Given that both of these addons contain potentially offensive material that, unlike any others, reflect particular political opinions of their original creator which I don’t believe Friendica should keep promoting as a project, I am pleading for an exception to the regular addon sunsetting workflow.

Both are mostly lists of translation strings with very little in the way of code that deserve to be kept around anyway. So, at least for the same reason these addons didn’t need a deprecated flag, I don’t think they should be moved to the deprecated-addons repository either.

Given that both of these addons contain potentially offensive material that, unlike any others, reflect particular political opinions of their original creator which I don’t believe Friendica should keep promoting as a project, I am pleading for an exception to the regular addon sunsetting workflow. Both are mostly lists of translation strings with very little in the way of code that deserve to be kept around anyway. So, at least for the same reason these addons didn’t need a deprecated flag, I don’t think they should be moved to the deprecated-addons repository either.
tobiasd commented 2022-08-10 09:24:59 +02:00 (Migrated from github.com)
Copy link

Ok, I see what you mean.

Ok, I see what you mean.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
2024.09

   
2024.12

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
2024.09
2024.12
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1278
No description provided.
Delete branch "task/remove-poke"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?