[twitter] Add support for unretweet and post/comment deletion #1211

Merged

MrPetovan merged 4 commits from task/11022-twitter-support-delete into develop

2021-11-27 13:29:19 +01:00

MrPetovan commented

2021-11-24 00:31:27 +01:00

(Migrated from github.com)

Closes https://github.com/friendica/friendica/issues/11022

Also:

Improve probe_detect hook function
Add item_by_link hook function

Remaining caveat: Comments posted on Twitter and imported in Friendica do not trigger any Notifier task, possibly because they are private to the user and don't require any remote deletion notifications sent. Comments posted on Friendica and mirrored on Twitter trigger the Notifier task and the Twitter counter-part will be deleted accordingly.

Depends on https://github.com/friendica/friendica/pull/11025 for the hook part.

Closes https://github.com/friendica/friendica/issues/11022 Also: - Improve probe_detect hook function - Add item_by_link hook function Remaining caveat: Comments posted on Twitter and imported in Friendica do not trigger any Notifier task, possibly because they are private to the user and don't require any remote deletion notifications sent. Comments posted on Friendica and mirrored on Twitter trigger the Notifier task and the Twitter counter-part will be deleted accordingly. Depends on https://github.com/friendica/friendica/pull/11025 for the hook part.

🚀 1

MrPetovan commented

2021-11-24 00:45:00 +01:00

(Migrated from github.com)

@annando Some checks don't seem to make sense in twitter_post_hook, like the checks on the pconfig twitter.import value in a hook meant to post data to Twitter. On the contrary we don't check the pcfonfig twitter.post value in the same hook function even though it is meant to control posting to Twitter.

@annando Some checks don't seem to make sense in `twitter_post_hook`, like the checks on the pconfig `twitter.import` value in a hook meant to post data *to* Twitter. On the contrary we don't check the pcfonfig `twitter.post` value in the same hook function even though it is meant to control posting to Twitter.

nupplaphil commented

2021-11-27 12:38:21 +01:00

(Migrated from github.com)

@MrPetovan shall I wait for @annando 's Feedback

annando commented

2021-11-27 13:19:19 +01:00

(Migrated from github.com)

That check for "import" is meant for the special handling of imported Twitter posts, I guess. So when we are not importing Tweets then we are stopping here. You can see here the origin: https://github.com/friendica/friendica-addons/pull/157/files