[securemail] template adapted to standard #1142

Merged

Tealk merged 4 commits from secure-mail into 2021.06-rc

2021-07-01 03:22:20 +02:00

Tealk commented

2021-06-29 11:20:18 +02:00

(Migrated from github.com)

The template adapted to the standard of the other addons

before

after

The template adapted to the standard of the other addons before ![image](https://user-images.githubusercontent.com/12276250/123772050-d8ab5580-d8cb-11eb-996b-c9184672cec9.png) after ![image](https://user-images.githubusercontent.com/12276250/123772075-dd700980-d8cb-11eb-89fa-d63ab619e45a.png)

MrPetovan (Migrated from github.com) reviewed 2021-06-29 14:57:22 +02:00

Tealk commented

2021-06-29 17:41:03 +02:00

(Migrated from github.com)

thanks for help @MrPetovan
i am not that knowledgeable in what the standard is, i just wanted it to look consistent

thanks for help @MrPetovan i am not that knowledgeable in what the standard is, i just wanted it to look consistent

MrPetovan (Migrated from github.com) requested changes 2021-06-29 19:12:11 +02:00

MrPetovan (Migrated from github.com) left a comment

Thank you for going with my changes, but it also requires a change in the securemail method processing the $_POST variable.

Thank you for going with my changes, but it also requires a change in the securemail method processing the `$_POST` variable.

MrPetovan commented

2021-06-30 03:57:52 +02:00

(Migrated from github.com)

Alternatively I can do it myself on your branch since you gave maintainers the right to add more changes, let me know which one you prefer.

Tealk commented

2021-06-30 08:25:53 +02:00

(Migrated from github.com)

Alternatively I can do it myself on your branch since you gave maintainers the right to add more changes, let me know which one you prefer.

how do you do that?
i am not on github very often

I only see the following setting and it has already been activated

> Alternatively I can do it myself on your branch since you gave maintainers the right to add more changes, let me know which one you prefer. how do you do that? i am not on github very often I only see the following setting and it has already been activated ![image](https://user-images.githubusercontent.com/12276250/123915747-1d44f880-d981-11eb-8d47-dbaf73960be7.png)

MrPetovan commented

2021-07-01 03:19:37 +02:00

(Migrated from github.com)

how do you do that?
i am not on github very often

In GitHub I can go to your fork you submitted the PR from and commit directly in the specific branch secure-mail.

From the command line I can add your fork as an additional remote and then push changes to your secure-mail branch from my working directory.

Deselecting the checkbox in your screenshot would prevent me or any other Friendica maintainer defined in the GitHub project from pushing to your branch.

> how do you do that? i am not on github very often In GitHub I can go to your fork you submitted the PR from and commit directly in the specific branch `secure-mail`. From the command line I can add your fork as an additional remote and then push changes to your `secure-mail` branch from my working directory. Deselecting the checkbox in your screenshot would prevent me or any other Friendica maintainer defined in the GitHub project from pushing to your branch.

MrPetovan (Migrated from github.com) requested changes 2021-07-01 03:20:33 +02:00

MrPetovan commented

2021-07-01 03:21:40 +02:00

(Migrated from github.com)

For example I was able to directly commit my suggested changes from review thanks to this checkbox being enabled.

Thank you for your work!

For example I was able to directly commit my suggested changes from review thanks to this checkbox being enabled. Thank you for your work!

MrPetovan (Migrated from github.com) approved these changes 2021-07-01 03:21:52 +02:00