Add SAML addon. #1111

Merged
very-ape merged 19 commits from develop into develop 2021-05-17 23:23:26 +02:00
very-ape commented 2021-05-17 06:18:27 +02:00 (Migrated from github.com)

I'm running a set of services for friends and family and using Keycloak for account management. All of the services I run use SAML to create a smooth, integrated experience via single sign-on and single logout.

This addon replaces the signup and login mechanisms with SAML-based SSO (and SLO).

I'm running a set of services for friends and family and using Keycloak for account management. All of the services I run use SAML to create a smooth, integrated experience via single sign-on and single logout. This addon replaces the signup and login mechanisms with SAML-based SSO (and SLO).
MrPetovan (Migrated from github.com) requested changes 2021-05-17 16:25:40 +02:00
very-ape commented 2021-05-17 20:14:45 +02:00 (Migrated from github.com)

Thanks for the quick turnaround on that code review! I believe I've addressed all the problems you noted and have also added some friendly messages for when the addon triggers before it's configured.

Thanks for the quick turnaround on that code review! I believe I've addressed all the problems you noted and have also added some friendly messages for when the addon triggers before it's configured.
MrPetovan (Migrated from github.com) requested changes 2021-05-17 21:01:48 +02:00
MrPetovan (Migrated from github.com) left a comment

Thank you for acting on the feedback, I have some more for you!

Thank you for acting on the feedback, I have some more for you!
very-ape commented 2021-05-17 22:02:14 +02:00 (Migrated from github.com)

Okay, I think I got everything this time.

Okay, I _think_ I got everything this time.
MrPetovan (Migrated from github.com) approved these changes 2021-05-17 23:20:03 +02:00
MrPetovan (Migrated from github.com) left a comment

Looks good to me, thanks!

Looks good to me, thanks!
tobiasd commented 2021-05-18 13:46:24 +02:00 (Migrated from github.com)

With #1113 merged, the translation of the SAML addon is now in the pipe for the translation teams

With #1113 merged, the translation of the SAML addon is now in the pipe for the translation teams
Sign in to join this conversation.
No description provided.