Add comments to functions in mailstream plugin #1108

Merged

mexon merged 2 commits from mat/mailstream-comments into develop

2021-05-08 21:44:27 +02:00

mexon commented

2021-05-08 20:41:35 +02:00

(Migrated from github.com)

I intend to do some refactoring in the mailstream plugin, including replacing the custom table with items in the worker queue. First though, here's some comments. Hopefully this will make the next PRs a bit easier to process.

MrPetovan (Migrated from github.com) approved these changes 2021-05-08 21:41:23 +02:00

MrPetovan commented

2021-05-08 21:42:11 +02:00

(Migrated from github.com)

Thank you for your work!

MrPetovan commented

2021-05-08 21:44:14 +02:00

(Migrated from github.com)

Since you mainly added comments, I didn't note the Code Standards violations that existed in this file, but if you're going for a more substantial refactoring, I will ask you to make this file adhere to the Friendica code standards.

mexon commented

2021-05-08 22:08:49 +02:00

(Migrated from github.com)

Since you mainly added comments, I didn't note the Code Standards violations that existed in this file, but if you're going for a more substantial refactoring, I will ask you to make this file adhere to the Friendica code standards.

Thanks for the pointer. Yep, I've got a branch and I'll submit a PR once I've tested it.

> Since you mainly added comments, I didn't note the Code Standards violations that existed in this file, but if you're going for a more substantial refactoring, I will ask you to make this file adhere to [the Friendica code standards](https://friendica.mrpetovan.com/help/Developers-Intro#Coding+standards). Thanks for the pointer. Yep, I've got a branch and I'll submit a PR once I've tested it.

👍 1