friendica/friendica-addons
7
2
Fork 14
Code Issues 3 Pull requests 3 Releases 16 Wiki Activity

SECURITY: don't allow retriever to change edited date and invoke notifier.

Browse source
This commit is contained in:
friendica 2013-08-25 17:51:14 -07:00
parent 3b104218cf
commit fd82e4f2ea
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
retriever/retriever.php
View file

@ -445,8 +445,8 @@ function retriever_apply_dom_filter($retriever, &$item, $resource) {
$item['body'] .= "\n\n" . t('Retrieved') . ' ' . date("Y-m-d") . ': [url='; $item['body'] .= "\n\n" . t('Retrieved') . ' ' . date("Y-m-d") . ': [url=';
$item['body'] .= $item['plink']; $item['body'] .= $item['plink'];
$item['body'] .= ']' . $item['plink'] . '[/url]'; $item['body'] .= ']' . $item['plink'] . '[/url]';
q("UPDATE `item` SET `body` = '%s', `edited` = '%s' WHERE `id` = %d", q("UPDATE `item` SET `body` = '%s' WHERE `id` = %d",
dbesc($item['body']), dbesc(datetime_convert('UTC', 'UTC')), intval($item['id'])); dbesc($item['body']), intval($item['id']));
} }
function retrieve_images(&$item) { function retrieve_images(&$item) {
@ -482,11 +482,11 @@ function retriever_check_item_completed(&$item)
$item['visible'] = $waiting ? 0 : 1; $item['visible'] = $waiting ? 0 : 1;
if (($item['id'] > 0) && ($old_visible != $item['visible'])) { if (($item['id'] > 0) && ($old_visible != $item['visible'])) {
logger('retriever_check_item_completed: changing visible flag to ' . $item['visible'] . ' and invoking notifier ("edit_post", ' . $item['id'] . ')', LOGGER_DEBUG); logger('retriever_check_item_completed: changing visible flag to ' . $item['visible'] . ' and invoking notifier ("edit_post", ' . $item['id'] . ')', LOGGER_DEBUG);
q("UPDATE `item` SET `visible` = %d, `edited` = '%s' WHERE `id` = %d", q("UPDATE `item` SET `visible` = %d WHERE `id` = %d",
intval($item['visible']), intval($item['visible']),
dbesc(datetime_convert('UTC', 'UTC')),
intval($item['id'])); intval($item['id']));
proc_run('php', "include/notifier.php", 'edit_post', $item['id']); // disable due to possible security issue
// proc_run('php', "include/notifier.php", 'edit_post', $item['id']);
} }
} }
@ -586,8 +586,7 @@ function retriever_transform_images(&$item, $resource) {
} }
$item['body'] = $transformed; $item['body'] = $transformed;
q("UPDATE `item` SET `edited` = '%s', `body` = '%s' WHERE `plink` = '%s' AND `uid` = %d AND `contact-id` = %d", q("UPDATE `item` SET `body` = '%s' WHERE `plink` = '%s' AND `uid` = %d AND `contact-id` = %d",
dbesc(datetime_convert('UTC', 'UTC')),
dbesc($item['body']), dbesc($item['body']),
dbesc($item['plink']), dbesc($item['plink']),
intval($item['uid']), intval($item['uid']),