Missing UNIQUE key for base_url and reduction to normalized URL

AndyHee commented

2018-05-14 15:40:57 +02:00

(Migrated from github.com)

The first issue is that there isn't a UNIQUE key on the base URL. The second issue is that there's no reduction to a normalized URL (without https) which would allow to rule out HTTP/HTTPS duplicates.

> The first issue is that there isn't a UNIQUE key on the base URL. The second issue is that there's no reduction to a normalized URL (without https) which would allow to rule out HTTP/HTTPS duplicates. Related to this issue: https://github.com/friendica/dir/issues/43 as discussed here: https://github.com/friendica/dir/issues/43#issuecomment-388548688.

MrPetovan commented

2018-11-05 06:26:01 +01:00

(Migrated from github.com)

This has been taken care of in the next version of the directory. Each server record uses the canonical URL of the server as given in the /friendica/json output, and we also record the various URLs that give the same output to remove de facto duplicates in the server polling queue.

This has been taken care of in the next version of the directory. Each server record uses the canonical URL of the server as given in the `/friendica/json` output, and we also record the various URLs that give the same output to remove de facto duplicates in the server polling queue.

AndyHee commented

2018-11-05 06:31:19 +01:00

(Migrated from github.com)

@MrPetovan I applaud your tireless effort. This is great news!

MrPetovan commented

2018-11-05 06:37:18 +01:00

(Migrated from github.com)

I kept getting annoyed having to work on the directory because its structure was similar to 2016 Friendica, and I didn't want to copy all the improvements since I couldn't use them directly. I even tried to set Friendica as a Composer dependency for the directory but it went nowhere.

So I started a new Directory project from scratch as a challenge to finally embrace Dependency Injection (hi @nupplaphil). It uses the same API as the current directory, which means that you can pull from and push to the new version, although the reverse is not possible yet, and never will in the case of push because of a fatal design flaw in the current directory.

You already are awake, so you get to see it first: https://dir.friendica.mrpetovan.com

I kept getting annoyed having to work on the directory because its structure was similar to 2016 Friendica, and I didn't want to copy all the improvements since I couldn't use them directly. I even tried to set Friendica as a Composer dependency for the directory but it went nowhere. So I started a new Directory project from scratch as a challenge to finally embrace Dependency Injection (hi @nupplaphil). It uses the same API as the current directory, which means that you can pull from and push to the new version, although the reverse is not possible yet, and never will in the case of push because of a fatal design flaw in the current directory. You already are awake, so you get to see it first: https://dir.friendica.mrpetovan.com

❤️ 1 🎉 1

AndyHee commented

2018-11-05 06:58:34 +01:00

(Migrated from github.com)

Wow! I'm impressed.

Thank you for the preview! Looking forward to its first release.

Wow! I'm impressed. Thank you for the preview! Looking forward to its first release.

👍 1

Missing UNIQUE key for base_url and reduction to normalized URL #55