Profiles with censored=1 should not be updated / unblocked by cron_sync.php #47

Closed
opened 2018-05-02 12:29:47 +02:00 by Quix0r · 16 comments
Quix0r commented 2018-05-02 12:29:47 +02:00 (Migrated from github.com)

If cron_sync.php runs, all accounts got unblocked. This should not happen as this makes anti-spam measurements unpractical.

If `cron_sync.php` runs, all accounts got unblocked. This should not happen as this makes anti-spam measurements unpractical.
MrPetovan commented 2018-05-02 14:51:33 +02:00 (Migrated from github.com)

Where is censored set in the first place? What does it affect? Just display in the public directory?

Where is `censored` set in the first place? What does it affect? Just display in the public directory?
Quix0r commented 2018-05-03 11:47:25 +02:00 (Migrated from github.com)

Table profile, it will effectively hide the profile from the list.

Table `profile`, it will effectively hide the profile from the list.
MrPetovan commented 2018-05-03 13:54:33 +02:00 (Migrated from github.com)

Ok thanks.

Ok thanks.
tobiasd commented 2018-05-06 10:53:20 +02:00 (Migrated from github.com)

Anyone could flag a profile in the directory, for being nsfw or dead, and then the directory admin could delete/censor those profiles from the directory node.

Anyone could flag a profile in the directory, for being nsfw or dead, and then the directory admin could delete/censor those profiles from the directory node.
MrPetovan commented 2018-05-06 15:40:06 +02:00 (Migrated from github.com)

Can you flag them in the current directory?

Can you flag them in the current directory?
Quix0r commented 2018-05-10 00:37:15 +02:00 (Migrated from github.com)

I mean the censored flag got reset after sync ran.

I mean the `censored` flag got reset after sync ran.
Quix0r commented 2018-05-10 00:41:08 +02:00 (Migrated from github.com)

And where is the flag button?

And where is the flag button?
MrPetovan commented 2018-05-10 02:07:35 +02:00 (Migrated from github.com)

You tell me, I've never seen the flag button.

You tell me, I've never seen the flag button.
tobiasd commented 2018-05-10 06:33:18 +02:00 (Migrated from github.com)

I guess somebody(TM) removed it for aesthetics and hopefully planned to include it back later on but then lost track of the issue. It was a simple interface, but at least one could report profiles and the admin of the directory could review those reports.

I guess somebody(TM) removed it for aesthetics and hopefully planned to include it back later on but then lost track of the issue. It was a simple interface, but at least one could report profiles and the admin of the directory could review those reports.
MrPetovan commented 2018-05-10 14:13:57 +02:00 (Migrated from github.com)

I've seen this in the code, with admin users able to log in to the directory and review the flagged accounts, but it seemed like old code.

I've seen this in the code, with admin users able to log in to the directory and review the flagged accounts, but it seemed like old code.
tobiasd commented 2018-05-10 19:30:37 +02:00 (Migrated from github.com)

It was actively used code till the layout switch. Every time I logged into the old directory there were some accounts flagged for review.

It was actively used code till the layout switch. Every time I logged into the old directory there were some accounts flagged for review.
MrPetovan commented 2018-05-10 19:56:23 +02:00 (Migrated from github.com)

Since I can't log in into the new directory, there aren't any flagged accounts anymore!

Since I can't log in into the new directory, there aren't any flagged accounts anymore!
tobiasd commented 2018-05-10 20:02:03 +02:00 (Migrated from github.com)

Which is not really a satisfactory situation for the vanishing of a useful and used function TBH But I'll close my eyes and don't see any SPAM until the feature comes back.

Which is not really a satisfactory situation for the vanishing of a useful and used function TBH But I'll close my eyes and don't see any SPAM until the feature comes back.
MrPetovan commented 2018-05-10 20:43:33 +02:00 (Migrated from github.com)

That's the spirit!

That's the spirit!
MrPetovan commented 2018-11-05 06:18:58 +01:00 (Migrated from github.com)

The next version of the directory uses a censored flag at the profile and the server level, which hides all the profiles registered on that server, as well as preventing future polling. It still is a manual task in the DB though. I may add a console task for this.

The next version of the directory uses a `censored` flag at the profile and the server level, which hides all the profiles registered on that server, as well as preventing future polling. It still is a manual task in the DB though. I may add a console task for this.
Quix0r commented 2018-11-11 11:55:53 +01:00 (Migrated from github.com)

Thank you for your work. :-)

Thank you for your work. :-)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#47
No description provided.