Rename plugin to addon

MrPetovan commented

2018-02-24 16:58:41 +01:00

(Migrated from github.com)

Fixes #40

Related to https://github.com/friendica/friendica/pull/4288 Fixes #40

annando commented

2018-02-24 18:43:48 +01:00

(Migrated from github.com)

Isn't there some SQL update script?

MrPetovan commented

2018-02-24 19:10:05 +01:00

(Migrated from github.com)

Not that I know of, this isn't Friendica with its fancy database versioning. Although it would be easier if there was a common Friendica library I could use as a dependency for the directory, it feels a little bit duplicated between the projects.

annando commented

2018-02-24 19:25:44 +01:00

(Migrated from github.com)

So do we need some shared Friendica core or should we integrate the directory into the current core?

tobiasd commented

2018-02-24 20:36:34 +01:00

(Migrated from github.com)

So do we need some shared Friendica core or should we integrate the
directory into the current core?

chuckles I see a wave developing. The dir project was separated to have a less complicate structure then the friendica project IIRC

> So do we need some shared Friendica core or should we integrate the > directory into the current core? *chuckles* I see a wave developing. The dir project was separated to have a less complicate structure then the friendica project IIRC

MrPetovan commented

2018-02-24 20:45:43 +01:00

(Migrated from github.com)

There are two separate concepts in Friendica. The whole library we built in src/, and the controllers and cronjobs we currently have in mod/. We usually call the library the Framework.

The directory doesn't need Friendica controllers but it can leverage Friendica framework, like all the classes in Util for example. Those classes could be in a separate repository that could be included as a dependency by both project. And when we update a Util class, both projects can use the updated version.

We don't need it because both projects work right now, and there isn't any new external need for it. We don't need it as well because there are multiple frameworks around who do the same stuff generally more elegantly, and we probably don't need to publish yet another framework that started as a specific project.

So we don't "need" it per se, but it would be a fun exercise at least for me. The drawback is that the shared library version has to be managed with regard to backward compatibility whereas we don't care about it when it's only used by Friendica.

There are two separate concepts in Friendica. The whole library we built in `src/`, and the controllers and cronjobs we currently have in `mod/`. We usually call the library the Framework. The directory doesn't need Friendica controllers but it can leverage Friendica framework, like all the classes in Util for example. Those classes could be in a separate repository that could be included as a dependency by both project. And when we update a Util class, both projects can use the updated version. We don't need it because both projects work right now, and there isn't any new external need for it. We don't need it as well because there are multiple frameworks around who do the same stuff generally more elegantly, and we probably don't need to publish yet another framework that started as a specific project. So we don't "need" it per se, but it would be a fun exercise at least for me. The drawback is that the shared library version has to be managed with regard to backward compatibility whereas we don't care about it when it's only used by Friendica.

annando commented

2018-02-26 21:07:00 +01:00

(Migrated from github.com)

I just realized that this file dfrndir.sql is the update script as well. So I guess it would be correct to keep the old structure at the top and to add some "alter" command to change the field name.

I just realized that this file ```dfrndir.sql``` is the update script as well. So I guess it would be correct to keep the old structure at the top and to add some "alter" command to change the field name.

MrPetovan commented

2018-02-26 21:12:32 +01:00

(Migrated from github.com)

There's no current update mechanism for the Friendica directory and I don't intend on maintaining one, so I personally won't change the dfrndir.sql file according to your feedback.

There's no current update mechanism for the Friendica directory and I don't intend on maintaining one, so I personally won't change the `dfrndir.sql` file according to your feedback.

annando commented

2018-02-27 11:28:44 +01:00

(Migrated from github.com)

Okay. There aren't many directory installations in the wild. But these installations will fail after pulling this code when they don't apply the database changes manually.

We need something for the update. Either a script or documentation or a mixture of both.

Okay. There aren't many directory installations in the wild. But these installations will fail after pulling this code when they don't apply the database changes manually. We need something for the update. Either a script or documentation or a mixture of both.

MrPetovan commented

2018-04-05 03:28:19 +02:00

(Migrated from github.com)

Merging as people are trying to set up their own directory and it puts them at odds with dir.friendica.social.

Merging as people are trying to set up their own directory and it puts them at odds with `dir.friendica.social`.

Rename plugin to addon #41