friendica/dir
6
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix health page not working #27

Merged
MrPetovan merged 5 commits from issue/#24 into master 2017-08-04 03:38:20 +02:00
Conversation 4 Commits 5 Files changed 9 +183 -143
MrPetovan commented 2017-08-02 03:08:40 +02:00 (Migrated from github.com)
Copy link

Fixes issue #24

  • Fix formatting
  • Add references to App
  • Fix parse error
  • Fix a bunch of notices
  • Remove inexplicable killme() for *_content pages preventing them from
    displaying
Fixes issue #24 - Fix formatting - Add references to App - Fix parse error - Fix a bunch of notices - Remove inexplicable killme() for *_content pages preventing them from displaying
tobiasd (Migrated from github.com) approved these changes 2017-08-02 06:07:12 +02:00
annando (Migrated from github.com) reviewed 2017-08-02 20:11:03 +02:00
annando (Migrated from github.com) left a comment
Copy link

Just some questions.

Just some questions.
maintenance.html
@ -0,0 +31,4 @@
</h2>
<p class="about">
The Friendica Directory is unavailable at this time, please connect with <a href="https://friendica.mrpetovan.com/profile/hypolite">hypolite@friendica.mrpetovan.com</a> for updates about its status.
annando (Migrated from github.com) commented 2017-08-02 20:10:45 +02:00
Copy link

I'm confused: Hadn't you added this here with the other PR as well?

I'm confused: Hadn't you added this here with the other PR as well?
mod/health.php
@ -186,3 +179,4 @@
if ($site['effective_base_url']) {
//The effective health status.
$r = q(
"SELECT * FROM `site-health`
annando (Migrated from github.com) commented 2017-08-02 20:07:51 +02:00
Copy link

Why is "versions" vanished?

Why is "versions" vanished?
MrPetovan (Migrated from github.com) reviewed 2017-08-02 20:20:49 +02:00
mod/health.php
@ -186,3 +179,4 @@
if ($site['effective_base_url']) {
//The effective health status.
$r = q(
"SELECT * FROM `site-health`
MrPetovan (Migrated from github.com) commented 2017-08-02 20:20:49 +02:00
Copy link

I have no idea, the variable didn't exist in the controller nor in the template.

I have no idea, the variable didn't exist in the controller nor in the template.
annando (Migrated from github.com) reviewed 2017-08-02 20:29:00 +02:00
mod/health.php
@ -186,3 +179,4 @@
if ($site['effective_base_url']) {
//The effective health status.
$r = q(
"SELECT * FROM `site-health`
annando (Migrated from github.com) commented 2017-08-02 20:29:00 +02:00
Copy link

Okay. When you had checked that, then It's fine for me.

Okay. When you had checked that, then It's fine for me.
Sign in to join this conversation.
Reviewers
No reviewers
tobiasd
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#27
No description provided.
Delete branch "issue/#24"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?