Dynamic version scoring #13

New Issue

Closed

opened 2017-03-02 10:07:34 +01:00 by Beanow · 5 comments

Beanow commented

2017-03-02 10:07:34 +01:00

(Migrated from github.com)

The health scoring function health_score_after_probe at include/site-health.php attributes scores to older versions. However this is hard-coded.

The database keeps track of what versions sites are running though. As can be seen for example in http://dir.friendi.ca/versions which comes from the site-health table's version column.

Since this follows a semver-like pattern it could be parsed and used to determine which stable major and minor versions are released. Meaning the scoring algorithm won't have to be updated every time.

Alternatively we could ask the Friendica devs to move the version number from boot.php to a separate file, like VERSION so we can request this file directly from the github master branch.

The health scoring function `health_score_after_probe` at `include/site-health.php` attributes scores to older versions. However this is hard-coded. The database keeps track of what versions sites are running though. As can be seen for example in http://dir.friendi.ca/versions which comes from the `site-health` table's `version` column. Since this follows a semver-like pattern it could be parsed and used to determine which stable major and minor versions are released. Meaning the scoring algorithm won't have to be updated every time. Alternatively we could ask the Friendica devs to move the version number from `boot.php` to a separate file, like `VERSION` so we can request this file directly from the github master branch.

tobiasd commented

2017-03-02 12:03:14 +01:00

(Migrated from github.com)

Alternatively we could ask the Friendica devs to move the version
number from boot.php to a separate file, like VERSION so we can
request this file directly from the github master branch.

The version of a node is available via the API, cant you use that?

api/statusnet/config.[xml|json]

> Alternatively we could ask the Friendica devs to move the version > number from `boot.php` to a separate file, like `VERSION` so we can > request this file directly from the github master branch. The version of a node is available via the API, cant you use that? api/statusnet/config.[xml|json]

Beanow commented

2017-03-02 13:39:28 +01:00

(Migrated from github.com)

@tobiasd this is what the current code does. It gets the version per server from /friendica/json. The difference is that you could use the code's master branch as your reference. Versus looking at servers in the wild.

@tobiasd this is what the current code does. It gets the version per server from `/friendica/json`. The difference is that you could use the **code's master branch** as your reference. Versus looking at **servers in the wild**.

tobiasd commented

2017-03-03 15:46:59 +01:00

(Migrated from github.com)

Yes, ok

tobiasd commented

2017-03-12 15:56:34 +01:00

(Migrated from github.com)

I've added a VERSION file with the 3.5.1 release.

MrPetovan commented

2018-11-05 06:04:36 +01:00

(Migrated from github.com)

The next version is checking for the current stable and develop version stored on https://git.friendi.ca to compute health score.