friendica/dir
6
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Cleanups and some fixes #12

Closed
Quix0r wants to merge 0 commits from cleanups/chmod-e_notice_white-space into master
pull from: cleanups/chmod-e_notice_white-space
merge into: friendica:master
Conversation 3 Commits - Files changed - +491 -838
Quix0r commented 2017-03-01 20:34:05 +01:00 (Migrated from github.com)
Copy link

This PR fixes CHMOD on non-executable files + an E_NOTICE in boot.php. It also renamed .htconfig.php as ignored files should never be committed (and this one contains sensitive informations). If only the line in .gitignore is removed, sensitive information can be committed and consequently published.

I also gave all JavaScript files a separate folder so "include" (if no longer needed) can be secured by .htaccess file (Deny from all should be okay).

The JavaScript library "Raphael" (or so?) is now residing in an own sub folder.

Most changes on those 185 files are CHMOD, don't wonder about it. :-)

This PR fixes CHMOD on non-executable files + an `E_NOTICE` in `boot.php`. It also renamed `.htconfig.php` as ignored files should never be committed (and this one contains sensitive informations). If only the line in `.gitignore` is removed, sensitive information can be committed and consequently published. I also gave all JavaScript files a separate folder so "include" (if no longer needed) can be secured by .htaccess file (`Deny from all` should be okay). The JavaScript library "Raphael" (or so?) is now residing in an own sub folder. Most changes on those 185 files are CHMOD, don't wonder about it. :-)
MrPetovan (Migrated from github.com) requested changes 2017-03-02 03:35:15 +01:00
view/head.tpl
MrPetovan (Migrated from github.com) commented 2017-03-02 03:35:13 +01:00
Copy link

Can you please leave the $baseurl for eventual subfolder urls (like /servers)?

Can you please leave the $baseurl for eventual subfolder urls (like `/servers`)?
tobiasd (Migrated from github.com) requested changes 2017-03-02 07:26:16 +01:00
.htconfig.php-dist
tobiasd (Migrated from github.com) commented 2017-03-02 07:20:24 +01:00
Copy link

The "dist" file is called htconfig.php without the dot in Friendica. I think it should be the same here.

The "dist" file is called `htconfig.php` without the dot in Friendica. I think it should be the same here.
Beanow commented 2017-03-02 09:44:12 +01:00 (Migrated from github.com)
Copy link

Be sure to have a look at https://github.com/Beanow/dir/tree/feature/redesign-prototype as well. There I had added /assets/js as I also added other static files like fonts and style sheets to this folder.

Be sure to have a look at https://github.com/Beanow/dir/tree/feature/redesign-prototype as well. There I had added `/assets/js` as I also added other static files like fonts and style sheets to this folder.
👍 2
Quix0r (Migrated from github.com) reviewed 2017-03-02 09:52:15 +01:00
.htconfig.php-dist
Quix0r (Migrated from github.com) commented 2017-03-02 09:52:15 +01:00
Copy link

Okay, will rename it when I'm home.

Okay, will rename it when I'm home.
Quix0r (Migrated from github.com) reviewed 2017-03-02 09:54:41 +01:00
view/head.tpl
Quix0r (Migrated from github.com) commented 2017-03-02 09:54:41 +01:00
Copy link

There is <base href="$baseurl" /> in line 2 which sets the base URL for all other URLs. I can test it at home where it will definedly be in a sub folder.

There is `<base href="$baseurl" />` in line 2 which sets the base URL for all other URLs. I can test it at home where it will definedly be in a sub folder.
Quix0r commented 2017-03-02 09:58:16 +01:00 (Migrated from github.com)
Copy link

@Beanow so I move them to /asset/js/ and later try to merge your changes into mine?

@Beanow so I move them to `/asset/js/` and later try to merge your changes into mine?
MrPetovan (Migrated from github.com) reviewed 2017-03-02 13:10:21 +01:00
view/head.tpl
MrPetovan (Migrated from github.com) commented 2017-03-02 13:10:20 +01:00
Copy link

That would be great. I don't use <base> because I prefer explicit absolute paths to implicit prepending, but I reckon it would work.

That would be great. I don't use `<base>` because I prefer explicit absolute paths to implicit prepending, but I reckon it would work.
Quix0r (Migrated from github.com) reviewed 2017-03-02 13:58:50 +01:00
view/head.tpl
Quix0r (Migrated from github.com) commented 2017-03-02 13:58:50 +01:00
Copy link

Okay, I didn't know that. I saw the same in Friendica and thought this might be the same here, too.

Okay, I didn't know that. I saw the same in `Friendica` and thought this might be the same here, too.
annando (Migrated from github.com) reviewed 2017-03-02 14:24:01 +01:00
view/head.tpl
annando (Migrated from github.com) commented 2017-03-02 14:24:01 +01:00
Copy link

I guess this are two different philosophies :-) I'm more with the <base> stuff.

I guess this are two different philosophies :-) I'm more with the ````<base>```` stuff.
MrPetovan commented 2017-05-05 03:54:29 +02:00 (Migrated from github.com)
Copy link

This PR has been included in the redesign-prototype branch I'm running right now.

This PR has been included in the redesign-prototype branch I'm running right now.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
tobiasd
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#12
No description provided.
Delete branch "cleanups/chmod-e_notice_white-space"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?