contact management: include important items like "remove" in dropdown menu #797

New issue

Closed

opened 2013-11-01 17:58:39 +01:00 by Ghost · 3 comments

Ghost commented

2013-11-01 17:58:39 +01:00

(Migrated from friendica.ydns.eu)

this is concerning the contacts section: when on the view to manage all contacts, each contact has a dropdown list with a few options.

This imo should only contain the most used and basic options. Remove is certainly a basic option but is currently missing. I suggest removing items like "View Photos" and add a "remove" option. When I'm in the section where I manage all my contacts I expect those options rather then content related options.

The current flow of having to select "edit contact" and only then being able to remove a contact, also forcing the user to leave the overview view is not really intuitive.

this is concerning the contacts section: when on the view to manage all contacts, each contact has a dropdown list with a few options. ![where's_the_remove_option](https://f.cloud.github.com/assets/5708172/1455213/855907b8-4316-11e3-9ea0-b6cc91a45351.png) This imo should only contain the most used and basic options. Remove is certainly a basic option but is currently missing. I suggest removing items like "View Photos" and add a "remove" option. When I'm in the section where I manage all my contacts I expect those options rather then content related options. The current flow of having to select "edit contact" and only then being able to remove a contact, also forcing the user to leave the overview view is not really intuitive.

Ghost commented

2013-11-03 11:18:48 +01:00

(Migrated from friendica.ydns.eu)

I have maybe a solution to fix this problem.

In /include/Contact.php
insert at line 199:
$contact_drop_link = "";
$contact_block_link = "";
$contact_ignore_link = "";

insert at line 215:
$contact_drop_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/drop';
$contact_block_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/block';
$contact_ignore_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/ignore';

and insert at line 230:
'drop' => array(t("Drop Contact"), $contact_drop_link),
'block' => array(t("Block Contact"), $contact_block_link),
'ignore' => array(t("Ignore Contact"), $contact_ignore_link),

Please remember, this solution is not tested.

Edit:
I have tested this solution and it works. I will add the drop option in the code. Pull Request: #810

I have maybe a solution to fix this problem. In /include/Contact.php insert at line 199: $contact_drop_link = ""; $contact_block_link = ""; $contact_ignore_link = ""; insert at line 215: $contact_drop_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/drop'; $contact_block_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/block'; $contact_ignore_link = $a->get_baseurl() . '/contacts/' . $contact['id'] . '/ignore'; and insert at line 230: 'drop' => array(t("Drop Contact"), $contact_drop_link), 'block' => array(t("Block Contact"), $contact_block_link), 'ignore' => array(t("Ignore Contact"), $contact_ignore_link), Please remember, this solution is not tested. Edit: I have tested this solution and it works. I will add the drop option in the code. Pull Request: #810

Ghost commented

2013-12-05 12:39:58 +01:00

(Migrated from friendica.ydns.eu)

Tested in Friendica, version 3.2.1745: I click "drop" item in the contacts options. Once clicked I find myself on the "Home" view. When I go back to contacts the contact is still there. So not fixed yet.

Ghost commented

2013-12-11 10:26:42 +01:00

(Migrated from friendica.ydns.eu)

same effect last time I tried it

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

friendica-test/friendica#797

No description provided.

Rows
Columns