716b959e33
Some code cleanup
2018-07-24 04:15:19 +00:00
de984cdaa1
Issue 5467: Fix worker and daemon
2018-07-24 03:42:44 +00:00
Michael Vogel
0e719f5398
Merge pull request #5478 from MrPetovan/task/5410-add-missing-use-statements
...
Add missing use statements after dbesc conversion
2018-07-24 03:57:20 +02:00
Roland Häder
00595de6a3
Fixes: ( #5477 )
...
- use DBA::isResult() and not count()
- fixed 4 E_NOTICE when POST fields are not set
2018-07-23 18:52:48 -04:00
Roland Häder
14a4d5eb59
Avoid no needed call on parse2str() when there is nothing to parse ( #5476 )
2018-07-23 18:52:07 -04:00
Hypolite Petovan
30fff2077c
Ad missing use statements after dbesc conversion
2018-07-23 18:44:05 -04:00
Michael Vogel
413424064c
Merge pull request #5439 from MrPetovan/task/5410-remove-dbesc
...
Move DBA to src/ part 4.1: Remove dbesc()
2018-07-23 21:51:49 +02:00
Jeroen De Meerleer
d57449623b
Added true to json_decode ( #5471 )
2018-07-23 15:51:08 -04:00
Hypolite Petovan
6141023640
Remove dbesc() and dba_timer() function declarations
2018-07-23 15:30:54 -04:00
Hypolite Petovan
a6fb3568f9
Rename dbesc to DBA::escape
2018-07-23 15:30:54 -04:00
Hypolite Petovan
d3a598f589
Update DBA::escape to match dbesc()
2018-07-23 15:13:42 -04:00
Michael Vogel
cfa68c52b9
Merge pull request #5438 from MrPetovan/task/5410-remove-dbm-class
...
Move DBA to src/ part 3.2: Remove DBM class
2018-07-23 21:05:32 +02:00
Hypolite Petovan
538b81d10d
Delete Database\DBM class file
2018-07-23 11:04:15 -04:00
Hypolite Petovan
aa26943f92
Rename DBA::esc_array to DBA::escapeArray
...
- Rename internal method DBA::esc_array_callback to
DBA::escapeArrayCallback
2018-07-23 11:04:15 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06
Use DateTimeFormat::utc() instead of DBM::date()
2018-07-23 10:57:47 -04:00
Hypolite Petovan
c55e389bbc
Add Database\DBM methods to Database\DBA
2018-07-23 10:57:47 -04:00
Hypolite Petovan
38f341e064
Add missing space between PHP path and script in App->proc_run ( #5468 )
2018-07-23 10:43:39 -04:00
Michael Vogel
2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods
...
Move DBA to src/ part 3.1: Rename DBA methods
2018-07-23 15:18:58 +02:00
Hypolite Petovan
b685ef37c9
Fix Fatal errors in Protocol\OStatus ( #5466 )
2018-07-23 07:48:44 -04:00
Michael Vogel
53876abfda
And some more removed notices in the core ( #5465 )
2018-07-23 07:43:18 -04:00
Philipp
cd52d0b3e9
Using getopt for CLI arguments ( #5446 )
...
* Adding Argument class to Friendica
* Adding Argument class to Friendica
* Adding Argument class to Friendica
* fixing arguments for `spawnWorker`
* Adding `use Friendica\BaseObject` to `ApiTest.php`
* Refactoring the argument-usages of Friendica
* Refactoring the argument-usages of Friendica
* removing superfluous []
2018-07-23 07:40:52 -04:00
Roland Häder
ea24ac9d95
Cleaned up: ( #5461 )
...
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)
2018-07-22 21:19:28 -04:00
Roland Häder
4eb6707dc9
Cleanup: ( #5463 )
...
- rewrote x() to empty() as it is deprecated
- fixed indending for some entries
2018-07-22 21:18:21 -04:00
Roland Häder
ffc70bee17
Fixes: ( #5462 )
...
- fixed E_NOTICE about missing array element "page-flags-raw" (should be
"page_flags_raw"?)
- same with account-type-raw -> account_type_raw
- added spaces to nicely indent code
2018-07-22 21:17:44 -04:00
Roland Häder
a27ef8d0c9
Prevents 4 E_NOTICEs when POST fields are not set. ( #5458 )
...
* Prevents 4 E_NOTICEs when POST fields are not set.
* Don't use x().
* Replaced usage of x() which is deprecated with !isset().
* Use empty() according to MrPetovan
2018-07-22 19:49:16 -04:00
Hypolite Petovan
cdd8e4fd9d
Rename DBA::get_db to DBA::getConnection
...
- Rename DBA::$db to DBA::$connection
2018-07-22 19:28:29 -04:00
Hypolite Petovan
415b982d39
Rename DBA::num_rows to DBA::numRows
2018-07-22 19:27:35 -04:00
Hypolite Petovan
1f2c0b98b5
Rename DBA::server_info to DBA::serverInfo
2018-07-22 19:27:35 -04:00
Hypolite Petovan
4db98eb43d
Rename DBA::inArray to DBA::toArray
2018-07-22 19:27:35 -04:00
Hypolite Petovan
f051ae1698
Rename DBA::fetch_first to DBA::fetchFirst
2018-07-22 19:27:34 -04:00
Hypolite Petovan
591939dfc0
Rename DBA::database_name to DBA::databaseName
2018-07-22 19:27:34 -04:00
Hypolite Petovan
abbaaf5aa5
Rename DBA::clean_query to DBA::cleanQuery
2018-07-22 19:27:34 -04:00
Hypolite Petovan
910e832dc2
Rename DBA::any_value_fallback to DBA::anyValueFallback
2018-07-22 19:27:34 -04:00
Hypolite Petovan
e42cf4d4fc
Rename DBA::affected_rows to DBA::affectedRows
2018-07-22 19:27:34 -04:00
Roland Häder
d3144e2837
Need to load "verb" from notify table, too. This whole thing is a maintenance ( #5459 )
...
nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.
2018-07-22 19:25:07 -04:00
Hypolite Petovan
bb99ac8111
Fix Fatal error in Protocol\Diaspora ( #5460 )
2018-07-22 19:22:41 -04:00
Roland Häder
ad857b4314
Fixed E_NOTICE when no valid result has been returned. ( #5457 )
2018-07-22 18:05:10 -04:00
Roland Häder
7876d6547b
Fixed E_NOTICEs when uploading profile picture ( #5456 )
...
* Fixed E_NOTICEs when uploading profile picture.
* Fixed E_NOTICEs when $_POST doesn't contain these fields.
2018-07-22 16:01:14 -04:00
Roland Häder
c17adaf333
Uncommon logger levels in Friendica ( #5453 )
...
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)
* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Hypolite Petovan
a202962f03
Fix yet another Fatal Error in Protocol\OStatus ( #5454 )
2018-07-22 13:32:34 -04:00
Hypolite Petovan
d6ccba79e0
Fix another Fatal error in Protocol\OStatus ( #5451 )
...
* Fix Fatal error in Protocol\OStatus
* Fix another Fatal error in Protocol\OStatus
2018-07-22 12:57:33 -04:00
Roland Häder
7d47152564
Fixed E_NOTICE in boot.php and DBA class ( #5430 )
...
* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed:
- better use `false` and `$port > 0`
* And better only provide `$port` when larger zero.
* Initialize `$port` with zero value (int) and not `false` (bool).
* Removed duplicate mysqli "import".
* `$post_update` is no longer used. Instead `$prefix` needs to be checked.
2018-07-22 12:53:46 -04:00
Hypolite Petovan
3500e50be9
Fix Fatal error in Protocol\OStatus ( #5450 )
2018-07-22 12:52:38 -04:00
Roland Häder
0a519f5001
Fixes/tye-hints ( #5449 )
...
- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
`if (!empty($foo['bar']))` instead
2018-07-22 12:35:20 -04:00
Roland Häder
2e332134d4
There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either ( #5448 )
...
declare it and push all other numbers higher or use LOGGER_NORMAL.
2018-07-22 12:33:28 -04:00
Roland Häder
2970a976d5
Fixes: ( #5447 )
...
- rewrote to first check if PID file is readable, then if found load it
- next addition is to cast it's content to int. Any non-integer content will
result in 0 (as I know).
- Give warnings a voice! (xdebug's scream option showed a warning)
- added some spaces for better readability
2018-07-22 12:28:39 -04:00
Jeroen De Meerleer
d1d2ee6b2f
Added a for-loop ( #5442 )
...
* Using json_decode instead of reinventing hot water
Guys, you could have told me ;)
* changed spaces to tabs
* Guess I'll need a beer ;)
2018-07-21 17:29:39 -04:00
Jeroen De Meerleer
ddaeb305bc
Worker-details: Using json_decode instead of reinventing hot water ( #5441 )
...
* Using json_decode instead of reinventing hot water
Guys, you could have told me ;)
* changed spaces to tabs
2018-07-21 13:24:03 -04:00