Hypolite Petovan
0bcf7b7c39
Fix PHP 7.2 sizeof notice messages in Protocol\PortableContact
2018-06-12 22:01:50 -04:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
Michael
c86111d193
Coding standards
2018-05-29 19:00:26 +00:00
Michael
8329705eba
New function to delete items for users
2018-05-29 05:22:57 +00:00
Michael
c70ebadd7d
Issue-3412 related: Don't send connection posts anymore
2018-05-19 19:34:51 +00:00
Michael
5d708fd9a9
Avaoid warning when no valid data could be read
2018-05-18 16:07:55 +00:00
Michael
b333c7ae2e
Bugfix: Only send a notifier when the item was really edited
2018-05-17 05:49:55 +00:00
Michael
e77cd17495
We do the notify stuff now directly in the item class
2018-05-15 19:50:29 +00:00
Michael
4a1bbd114c
Lower priority for "remote self"
2018-05-15 19:29:14 +00:00
Michael
8564eeec4e
Fix: public comments weren't distributed to the followers.
2018-05-15 04:33:28 +00:00
Roland Häder
69ac6feff7
Continued:
...
- you can directly use constant($var) instead of this switch()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
Roland Häder
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
Michael
dcfd81e2ee
Some corrections
2018-05-14 22:50:04 +02:00
Michael
d54c79a772
Replace old database queries with the new ones
2018-05-14 22:50:04 +02:00
Roland Häder
11dcb31960
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Häder
ce07c20130
PHP5 does not support native type-hints, except array
+ used dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Häder
6579396627
removed TODO, one day this all needs refacturizing ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Häder
7526afcf13
Continued:
...
- converted multiple single-line comments into one multi-line comment (please
stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Häder
f5f1650b62
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Häder
1fcd4f52e7
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Häder
87bb934f8f
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Häder
116d0ee1e0
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Häder
e5c4b0203a
added more curly braces + a bit more usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:00 +02:00
Michael
3bb5a416f8
Some corrections
2018-05-14 22:50:00 +02:00
Michael
8b775d48f9
Replace old database queries with the new ones
2018-05-14 22:50:00 +02:00
Roland Häder
dd6fd32883
rewrote based on CR by @Annando, thank you. It is now clear to me.
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:59 +02:00
Roland Häder
25fd270959
Continued:
...
- added spaces and curly braces
- added more TODOs as there really more to be done
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
Roland Häder
fc4d1296e3
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
Roland Häder
4d5c61395e
PHP5 does not support native type-hints, except array
+ used dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
Roland Häder
03f283ca36
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Häder
d2d6200669
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Häder
be3d0a90a5
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Häder
b823708c50
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Hypolite Petovan
f937dabc9e
Merge pull request #5044 from annando/no-feed-reshare
...
We mustn't reshare a feed item (only DFRN and Diaspora)
2018-05-13 18:31:58 -04:00
Michael
57bd073ffd
We mustn't reshare a feed item (only DFRN and Diaspora)
2018-05-13 18:31:01 +00:00
Roland Häder
99440f3c56
Beatification:
...
- added space after curly braces (MrPetovan)
- added TODO for possible rewrite candidate
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 14:21:53 +02:00
Hypolite Petovan
ec626fb76c
Merge pull request #5036 from Alkarex/fix-constants
...
Fix wrong use of class constants
2018-05-13 04:38:32 -04:00
Alexandre Alapetite
736c76d068
Simplify constant names
...
https://github.com/friendica/friendica/pull/5036#discussion_r187792865
2018-05-13 10:34:33 +02:00
Alexandre Alapetite
41a8c62bee
Fix wrong use of class constants
...
http://php.net/manual/language.oop5.constants.php
2018-05-13 10:07:15 +02:00
Roland Häder
445cc1cb99
Fixes:
...
- brought back comment (ops)
- DBM is the class name (not dbm)
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 10:06:43 +02:00
Roland Häder
3191fee763
Ops, one to much ...
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 10:02:47 +02:00
Michael
926c9719e0
Avoid SQL error with empty "bd" field
2018-05-11 15:27:19 +00:00
Michael
79a343a69a
Only set the "updated" value when it contains a value
2018-05-11 10:44:28 +00:00
Michael
6d4f3e8ee2
Issue 4997: Avoid database duplicates
2018-05-10 12:49:28 +00:00
Roland Häder
cf9fa51f2f
Continued:
...
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
long time around in PHP) anything can be handled over to the method/function.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-10 13:07:21 +02:00
Roland Häder
f66cb9b0a3
added more curly braces + a bit more usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-10 13:07:21 +02:00
Michael
40d3e7982c
Adopt the relay definition according to the suggestions from @jaywink
2018-05-10 11:04:18 +00:00
Hypolite Petovan
3a3a4807a8
Merge pull request #4978 from annando/dba-2
...
Diaspora: Fix person/contact retraction
2018-05-04 18:04:38 -04:00
Michael
dfa0dbf33f
Ups
2018-05-04 21:33:15 +00:00
Michael
1230ff146a
"remote-self" is now working for Diaspora and Twitter as well
2018-05-04 21:12:13 +00:00