bitPickups/friendica_2021.01_tupambae_shared_hosting
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Do not cache Contact::getDetailsByURL result if it doesn't come from the DB

Browse source 
- Address https://github.com/friendica/friendica/issues/8000#issuecomment-592169621
This commit is contained in:
Hypolite Petovan 2020-02-29 11:41:33 -05:00
parent 5ca98c17b6
commit dd999164c6
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Model/Contact.php
View file

@ -1037,6 +1037,7 @@ class Contact
} }
if (DBA::isResult($r)) { if (DBA::isResult($r)) {
$authoritativeResult = true;
// If there is more than one entry we filter out the connector networks // If there is more than one entry we filter out the connector networks
if (count($r) > 1) { if (count($r) > 1) {
foreach ($r as $id => $result) { foreach ($r as $id => $result) {
@ -1070,6 +1071,7 @@ class Contact
$profile["bd"] = DBA::NULL_DATE; $profile["bd"] = DBA::NULL_DATE;
} }
} else { } else {
$authoritativeResult = false;
$profile = $default; $profile = $default;
} }
@ -1106,7 +1108,11 @@ class Contact
$profile["birthday"] = DBA::NULL_DATE; $profile["birthday"] = DBA::NULL_DATE;
} }
// Only cache the result if it came from the DB since this method is used in widely different contexts
// @see display_fetch_author for an example of $default parameter diverging from the DB result
if ($authoritativeResult) {
$cache[$url][$uid] = $profile; $cache[$url][$uid] = $profile;
}
return $profile; return $profile;
} }