Improve contactgroupChangeMember() javascript function

- Add usage of new /group/123/add|remove/123 URL
- Add checkbox revert in case of error
This commit is contained in:
Hypolite Petovan 2019-02-23 15:36:06 -05:00
parent 6376293218
commit 0a58e4c952
4 changed files with 20 additions and 6 deletions

View file

@ -793,11 +793,25 @@ function profChangeMember(gid,cid) {
});
}
function contactgroupChangeMember(gid,cid) {
function contactgroupChangeMember(checkbox, gid, cid) {
let url;
// checkbox.checked is the checkbox state after the click
if (checkbox.checked) {
url = 'group/' + gid + '/add/' + cid;
} else {
url = 'group/' + gid + '/remove/' + cid;
}
$('body').css('cursor', 'wait');
$.get('contactgroup/' + gid + '/' + cid, function(data) {
$('body').css('cursor', 'auto');
$.post(url)
.error(function () {
// Restores previous state in case of error
checkbox.checked = !checkbox.checked;
})
.always(function() {
$('body').css('cursor', 'auto');
});
return true;
}
function checkboxhighlight(box) {

View file

@ -9,7 +9,7 @@
{{if $group.cid}}
<input type="checkbox"
class="{{if $group.selected}}ticked{{else}}unticked {{/if}} action"
onclick="contactgroupChangeMember('{{$group.id}}','{{$group.cid}}');return true;"
onclick="return contactgroupChangeMember(this, '{{$group.id}}','{{$group.cid}}');"
{{if $group.ismember}}checked="checked"{{/if}}
/>
{{/if}}

View file

@ -28,7 +28,7 @@
<input type="checkbox"
id="sidebar-group-checkbox-{{$group.id}}"
class="{{if $group.selected}}ticked{{else}}unticked {{/if}} action"
onclick="contactgroupChangeMember('{{$group.id}}','{{$group.cid}}');return true;"
onclick="return contactgroupChangeMember(this, '{{$group.id}}','{{$group.cid}}');"
{{if $group.ismember}}checked="checked"{{/if}}
aria-checked="{{if $group.ismember}}true{{else}}false{{/if}}"
/>

View file

@ -17,7 +17,7 @@
{{if $group.cid}}
<input type="checkbox"
class="{{if $group.selected}}ticked{{else}}unticked {{/if}} action"
onclick="contactgroupChangeMember('{{$group.id}}','{{$group.cid}}');return true;"
onclick="return contactgroupChangeMember(this, '{{$group.id}}','{{$group.cid}}');"
{{if $group.ismember}}checked="checked"{{/if}}
/>
{{/if}}