Hypolite Petovan
ce75177d4e
Merge pull request #5022 from Rudloff/feature/test_api
...
Add API tests
2018-05-16 08:25:11 -04:00
f34d72c143
Fixes:
...
- used empty() instead of x()
- removed superflous count()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:22 +02:00
d0c7ba5257
Fixed parser error
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:21 +02:00
debcdea82a
Continued:
...
- merged 2 if() into one with &&
- added TODO for possible rewrite (avoid "complex" code)
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
bacb7b70f6
Cleanups:
...
- added empty lines
- removed old-lost commented out line
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
94a02f8572
Continued:
...
- return is a keyword, not a function, so don't add braces here
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
e0a07d5f27
Continued:
...
- used x() to make sure the array key is there, else an E_NOTICE is triggered
- added type-hints where it is safe
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:04 +02:00
47f95855c0
added spaces + some curly braces + some usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
de50d62b81
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
35ada99954
Opps, added missing curly brace.
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
78ffd5b80f
fixed parser error
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
1c9dc6526f
Continued:
...
- added more curly braces
- replaced if (blaFoo()) { return true; } return false; with return blaFoo();
- added spaces
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
337824f649
Continued:
...
- added curly braces/spaces
- added TODOs (type-hints, old-lost code)
- more usage of dbm::is_result()
- combined some if() return stuff into a simple return statement
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
c3c9a53364
added spaces + curly braces and TODOs for upcoming type-hint rewrite. Please
...
note that PHP5 allows 'array' as type-hint already (+ interface/class name).
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
61fdc32d2f
Continued a bit:
...
- more spaces added
- more curly braces added
- let's use x($_FOO, 'bar') and not isset($_FOOT['bar'])
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
09384119b1
added spaces + some curly braces + some usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
c7e256f9de
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
1a61cee5a7
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
f7ceea7a85
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
5b56f189ae
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
bc259cdc44
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
Pierre Rudloff
3195d6e125
Add API tests
2018-05-10 19:12:00 +02:00
Pierre Rudloff
9bb11ccfa5
$attachments should aways be an array
...
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Pierre Rudloff
23371880e8
$called_api should always be an array
...
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Hypolite Petovan
3a3a4807a8
Merge pull request #4978 from annando/dba-2
...
Diaspora: Fix person/contact retraction
2018-05-04 18:04:38 -04:00
7cd7b1a9bf
Some more replaced queries
2018-05-04 21:43:29 +00:00
125afb4ae5
Suppress blocked contacts from being displayed
2018-05-04 21:27:20 +00:00
a83970bc0e
Some more dba stuff
2018-05-04 06:33:36 +00:00
4ad655ab80
Replace old database queries with the new ones
2018-05-02 19:26:15 +00:00
b4f5311e7f
Add Install Mode
...
- merge `friendica/develop` to `nupplaphil/install_mode`
2018-04-29 20:15:12 +02:00
Michael Vogel
bd0ba24518
Merge pull request #4951 from MrPetovan/bug/4946-move-current-theme-to-app
...
Move current_theme() to App
2018-04-29 19:11:49 +02:00
78f563407a
Fix PR 4942: Fixed item query
2018-04-29 16:32:46 +00:00
Hypolite Petovan
20289393da
Fix own post check for content filter
2018-04-28 19:11:11 -04:00
Hypolite Petovan
fde3d6f870
Replace current_theme() and current_theme_url() calls
2018-04-28 18:37:25 -04:00
Hypolite Petovan
9edff6cc5c
Add exception for self-contact in item_joins()
2018-04-28 11:38:01 -04:00
1ab965c944
Add Install Mode
...
- merged `friendica/develop` to `nupplaPhil/install_mode`
- content merged `mod/install.php` to `src/Class/`
2018-04-28 15:11:01 +02:00
Hypolite Petovan
c417f779c4
Add missing readonly check for displaying items in item_joins
2018-04-28 07:47:02 -04:00
a97ad9dc42
Add Install Mode (Part 2)
...
- Added constants to class `App`
- Added global App-Mode to `dba:connect()` instead parameter `$install`
2018-04-28 12:36:40 +02:00
d5b68cd146
Add a App-Mode with defined constants
...
- Normal Mode = 0
- Install Mode = 1
- Maintenance Mode = 2
Moved Install-Mode check to class `App`
Replaced all maintenance and install checks with $a->mode checks
2018-04-27 21:07:04 +02:00
6973aaefc2
Add Install Mode
...
- Added $install_mode in Class App instead
- Extracted the install business logic to a new Class Install
- Replaced all $a->module == 'install' with $a->install_mode
2018-04-23 22:56:59 +02:00
Hypolite Petovan
a84477ed2d
Fix count() warning in include/dba.php
2018-04-23 00:00:06 -04:00
Hypolite Petovan
48122733b8
Move content filter HTML in a template
2018-04-22 18:02:00 -04:00
Hypolite Petovan
4cfb12e9d9
Add one-line content filter when there's only one reason
2018-04-22 14:28:34 -04:00
Hypolite Petovan
273dde508b
Add default value doc for options.cascade in dba::delete
2018-04-22 11:34:41 -04:00
Hypolite Petovan
0a026515bd
Add documentation for $options parameter in dba::delete
2018-04-22 11:33:20 -04:00
Hypolite Petovan
ba3f721524
Prevent side effect with cascade => false in dba::delete
2018-04-22 04:46:46 -04:00
Hypolite Petovan
18078ce7a4
Prevent infinite loop when a dbstructure_definition hook is orphan
...
- Add cascade option to dba::delete
- use cascade = false for orphan hook deletion
2018-04-21 20:34:07 -04:00
Hypolite Petovan
98f64ed824
Replace duplicate behaviors by Model\Term::populateTagsFromItem
...
- Replaced in include/conversation
- Replaced in include/text
2018-04-16 22:22:58 -04:00
Hypolite Petovan
54b75026fc
Add header support for security token check
2018-04-16 22:22:58 -04:00
