Merge pull request #11692 from MrPetovan/bug/fatal-errors

Convert potential spaces in Memcache(d) key names

src/Core/Cache/Type/MemcacheCache.php

@@ -68,6 +68,17 @@ class MemcacheCache extends AbstractCache implements ICanCacheInMemory
 		}
 	}
 
+	/**
+	 * Memcache doesn't allow spaces in keys
+	 *
+	 * @param string $key
+	 * @return string
+	 */
+	protected function getCacheKey(string $key): string
+	{
+		return str_replace(' ', '_', parent::getCacheKey($key));
+	}
+
 	/**
 	 * (@inheritdoc)
 	 */

src/Core/Cache/Type/MemcachedCache.php

@@ -93,6 +93,17 @@ class MemcachedCache extends AbstractCache implements ICanCacheInMemory
 		}
 	}
 
+	/**
+	 * Memcached doesn't allow spaces in keys
+	 *
+	 * @param string $key
+	 * @return string
+	 */
+	protected function getCacheKey(string $key): string
+	{
+		return str_replace(' ', '_', parent::getCacheKey($key));
+	}
+
 	/**
 	 * (@inheritdoc)
 	 */

src/Protocol/OStatus.php

@@ -2017,7 +2017,7 @@ class OStatus
 	 * cache or it is empty
 	 *
 	 * @param string  $owner_nick  Nickname of the feed owner
-	 * @param string  $last_update Date of the last update
+	 * @param string  $last_update Date of the last update (in "Y-m-d H:i:s" format)
 	 * @param integer $max_items   Number of maximum items to fetch
 	 * @param string  $filter      Feed items filter (activity, posts or comments)
 	 * @param boolean $nocache     Wether to bypass caching

tests/src/Core/Cache/CacheTest.php

@@ -237,4 +237,13 @@ abstract class CacheTest extends MockedTest
 		self::assertNotContains('value1', $list);
 		self::assertNotContains('value2', $list);
 	}
+
+	/**
+	 * @small
+	 */
+	public function testSpaceInKey()
+	{
+		self::assertTrue($this->instance->set('key space', 'value'));
+		self::assertEquals('value', $this->instance->get('key space'));
+	}
 }