bitPickups/friendica_2020-09-1_sharedHosting
1
0
Fork 0
Code Pull requests Activity

This will 2 things:

Browse source 
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
   just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
   been created, not even empty which could have side effects

Thanks to @annando to make me rethink this part of code.
This commit is contained in:
Roland Häder 2022-06-16 15:08:04 +02:00
parent 7814ba4fc4
commit f2b7326650
Signed by: roland
GPG key ID: C82EDE5DDFA0BA77
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Model/APContact.php
View file

@ -242,9 +242,7 @@ class APContact
}
$aboutHtml = JsonLD::fetchElement($compacted, 'as:summary', '@value');
if ($aboutHtml != "") {
$apcontact['about'] = HTML::toBBCode($aboutHtml);
}
$apcontact['about'] = (!empty($aboutHtml) ? HTML::toBBCode($aboutHtml) : '');
$ims = JsonLD::fetchElementArray($compacted, 'vcard:hasInstantMessage');