Improve code standards in Model\Item
This commit is contained in:
parent
2fa9d49632
commit
d9361f2b81
1 changed files with 9 additions and 10 deletions
|
@ -3146,18 +3146,18 @@ class Item
|
|||
*/
|
||||
public static function makeImageGrid(array $images): string
|
||||
{
|
||||
$landscapeimages = array();
|
||||
$portraitimages = array();
|
||||
$landscapeimages = [];
|
||||
$portraitimages = [];
|
||||
|
||||
foreach ($images as $image) {
|
||||
($image['attachment']['width'] > $image['attachment']['height']) ? ($landscapeimages[] = $image) : ($portraitimages[] = $image);
|
||||
}
|
||||
|
||||
// Image for first column (fc) and second column (sc)
|
||||
$images_fc = array();
|
||||
$images_sc = array();
|
||||
$lcount = count($landscapeimages);
|
||||
$pcount = count($portraitimages);
|
||||
$images_fc = [];
|
||||
$images_sc = [];
|
||||
$lcount = count($landscapeimages);
|
||||
$pcount = count($portraitimages);
|
||||
if ($lcount == 0 || $pcount == 0) {
|
||||
if ($lcount == 0) {
|
||||
// only portrait
|
||||
|
@ -3424,9 +3424,8 @@ class Item
|
|||
$media = '';
|
||||
if (count($images) > 1) {
|
||||
$media = self::makeImageGrid($images);
|
||||
}
|
||||
elseif (count($images) == 1) {
|
||||
$media = $media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image.tpl'), [
|
||||
} elseif (count($images) == 1) {
|
||||
$media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image.tpl'), [
|
||||
'$image' => $images[0],
|
||||
]);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue