Merge pull request #10525 from MrPetovan/bug/fatal-errors

Add Exception for unexpected case

src/Model/APContact.php

@@ -28,6 +28,7 @@ use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Database\DBStructure;
 use Friendica\DI;
+use Friendica\Network\HTTPException;
 use Friendica\Network\Probe;
 use Friendica\Protocol\ActivityNamespace;
 use Friendica\Protocol\ActivityPub;
@@ -178,8 +179,12 @@ class APContact
 		}
 
 		if (Network::isLocalLink($url) && ($local_uid = User::getIdForURL($url))) {
-			$data  = Transmitter::getProfile($local_uid);
+			try {
-			$local_owner = User::getOwnerDataById($local_uid);
+				$data = Transmitter::getProfile($local_uid);
+				$local_owner = User::getOwnerDataById($local_uid);
+			} catch(HTTPException\NotFoundException $e) {
+				$data = null;
+			}
 		}
 
 		if (empty($data)) {

src/Module/Friendica.php

@@ -29,6 +29,7 @@ use Friendica\Core\System;
 use Friendica\Database\PostUpdate;
 use Friendica\DI;
 use Friendica\Model\User;
+use Friendica\Network\HTTPException;
 use Friendica\Protocol\ActivityPub;
 
 /**
@@ -112,11 +113,13 @@ class Friendica extends BaseModule
 	public static function rawContent(array $parameters = [])
 	{
 		if (ActivityPub::isRequest()) {
-			$data = ActivityPub\Transmitter::getProfile(0);
+			try {
-			if (!empty($data)) {
+				$data = ActivityPub\Transmitter::getProfile(0);
 				header('Access-Control-Allow-Origin: *');
 				header('Cache-Control: max-age=23200, stale-while-revalidate=23200');
 				System::jsonExit($data, 'application/activity+json');
+			} catch (HTTPException\NotFoundException $e) {
+				System::jsonError(404, ['error' => 'Record not found']);
 			}
 		}
 

src/Module/Profile/Profile.php

@@ -52,12 +52,13 @@ class Profile extends BaseProfile
 		if (ActivityPub::isRequest()) {
 			$user = DBA::selectFirst('user', ['uid'], ['nickname' => $parameters['nickname']]);
 			if (DBA::isResult($user)) {
-				// The function returns an empty array when the account is removed, expired or blocked
+				try {
-				$data = ActivityPub\Transmitter::getProfile($user['uid']);
+					$data = ActivityPub\Transmitter::getProfile($user['uid']);
-				if (!empty($data)) {
 					header('Access-Control-Allow-Origin: *');
 					header('Cache-Control: max-age=23200, stale-while-revalidate=23200');
 					System::jsonExit($data, 'application/activity+json');
+				} catch (HTTPException\NotFoundException $e) {
+					System::jsonError(404, ['error' => 'Record not found']);
 				}
 			}
 

src/Network/Probe.php

@@ -23,6 +23,7 @@ namespace Friendica\Network;
 
 use DOMDocument;
 use DomXPath;
+use Exception;
 use Friendica\Core\Hook;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
@@ -2198,10 +2199,17 @@ class Probe
 	 *
 	 * @param string $url
 	 * @return array probed data
+	 * @throws HTTPException\InternalServerErrorException
+	 * @throws HTTPException\NotFoundException
 	 */
-	private static function localProbe(string $url)
+	private static function localProbe(string $url): array
 	{
-		if ($uid = User::getIdForURL($url)) {
+		try {
+			$uid = User::getIdForURL($url);
+			if (!$uid) {
+				throw new HTTPException\NotFoundException('User not found.');
+			}
+
 			$profile   = User::getOwnerDataById($uid);
 			$approfile = ActivityPub\Transmitter::getProfile($uid);
 
@@ -2209,7 +2217,8 @@ class Probe
 				$profile['gsid'] = GServer::getID($approfile['generator']['url']);
 			}
 
-			$data = ['name' => $profile['name'], 'nick' => $profile['nick'], 'guid' => $approfile['diaspora:guid'] ?? '',
+			$data = [
+				'name' => $profile['name'], 'nick' => $profile['nick'], 'guid' => $approfile['diaspora:guid'] ?? '',
 				'url' => $profile['url'], 'addr' => $profile['addr'], 'alias' => $profile['alias'],
 				'photo' => Contact::getAvatarUrlForId($profile['id'], $profile['updated']),
 				'header' => $profile['header'] ? Contact::getHeaderUrlForId($profile['id'], $profile['updated']) : '',
@@ -2222,12 +2231,16 @@ class Probe
 				'inbox' => $approfile['inbox'], 'outbox' => $approfile['outbox'],
 				'sharedinbox' => $approfile['endpoints']['sharedInbox'], 'network' => Protocol::DFRN,
 				'pubkey' => $profile['upubkey'], 'baseurl' => $approfile['generator']['url'], 'gsid' => $profile['gsid'],
-				'manually-approve' => in_array($profile['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])];
+				'manually-approve' => in_array($profile['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])
-		} else {
+			];
+		} catch (Exception $e) {
 			// Default values for non existing targets
-			$data = ['name' => $url, 'nick' => $url, 'url' => $url, 'network' => Protocol::PHANTOM,
+			$data = [
-				'photo' => DI::baseUrl() . Contact::DEFAULT_AVATAR_PHOTO];
+				'name' => $url, 'nick' => $url, 'url' => $url, 'network' => Protocol::PHANTOM,
+				'photo' => DI::baseUrl() . Contact::DEFAULT_AVATAR_PHOTO
+			];
 		}
+
 		return self::rearrangeData($data);
 	}
 }

src/Protocol/ActivityPub/Transmitter.php

@@ -23,7 +23,6 @@ namespace Friendica\Protocol\ActivityPub;
 
 use Friendica\Content\Feature;
 use Friendica\Content\Text\BBCode;
-use Friendica\Content\Text\Plaintext;
 use Friendica\Core\Cache\Duration;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
@@ -35,12 +34,12 @@ use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\GServer;
 use Friendica\Model\Item;
-use Friendica\Model\ItemURI;
-use Friendica\Model\Profile;
 use Friendica\Model\Photo;
 use Friendica\Model\Post;
+use Friendica\Model\Profile;
 use Friendica\Model\Tag;
 use Friendica\Model\User;
+use Friendica\Network\HTTPException;
 use Friendica\Protocol\Activity;
 use Friendica\Protocol\ActivityPub;
 use Friendica\Protocol\Relay;
@@ -310,13 +309,18 @@ class Transmitter
 	/**
 	 * Return the ActivityPub profile of the given user
 	 *
-	 * @param integer $uid User ID
+	 * @param int $uid User ID
 	 * @return array with profile data
-	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 * @throws HTTPException\NotFoundException
+	 * @throws HTTPException\InternalServerErrorException
 	 */
-	public static function getProfile($uid)
+	public static function getProfile(int $uid): array
 	{
 		$owner = User::getOwnerDataById($uid);
+		if (!isset($owner['id'])) {
+			DI::logger()->error('Unable to find owner data for uid', ['uid' => $uid, 'callstack' => System::callstack(20)]);
+			throw new HTTPException\NotFoundException('User not found.');
+		}
 
 		$data = ['@context' => ActivityPub::CONTEXT];
 		$data['id'] = $owner['url'];
@@ -1855,10 +1859,11 @@ class Transmitter
 	 * @param string  $inbox Target inbox
 	 *
 	 * @return boolean was the transmission successful?
-	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 * @throws HTTPException\InternalServerErrorException
+	 * @throws HTTPException\NotFoundException
 	 * @throws \ImagickException
 	 */
-	public static function sendProfileUpdate($uid, $inbox)
+	public static function sendProfileUpdate(int $uid, string $inbox): bool
 	{
 		$owner = User::getOwnerDataById($uid);
 		$profile = APContact::getByURL($owner['url']);