1
0
Fork 0

More usage of dbm::is_result($r) instead of count($r):

- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions

View file

@ -44,7 +44,7 @@ function uexport_content(&$a){
function _uexport_multirow($query) {
$result = array();
$r = q($query);
// if(count($r)) {
// if(dbm::is_result($r)) {
if ($r){
foreach($r as $rr){
$p = array();
@ -130,7 +130,7 @@ function uexport_all(&$a) {
$r = q("SELECT count(*) as `total` FROM `item` WHERE `uid` = %d ",
intval(local_user())
);
if(count($r))
if(dbm::is_result($r))
$total = $r[0]['total'];
// chunk the output to avoid exhausting memory
@ -142,7 +142,7 @@ function uexport_all(&$a) {
intval($x),
intval(500)
);
/*if(count($r)) {
/*if(dbm::is_result($r)) {
foreach($r as $rr)
foreach($rr as $k => $v)
$item[][$k] = $v;