bitPickups/friendica_2020-09-1_sharedHosting
1
0
Fork 0
Code Pull requests Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

8
mod/subthread.php
View file

@ -20,7 +20,7 @@ function subthread_content(&$a) {
dbesc($item_id)
);
if(! $item_id || (! count($r))) {
if(! $item_id || (! dbm::is_result($r))) {
logger('subthread: no item ' . $item_id);
return;
}
@ -41,7 +41,7 @@ function subthread_content(&$a) {
intval($item['contact-id']),
intval($item['uid'])
);
if(! count($r))
if(! dbm::is_result($r))
return;
if(! $r[0]['self'])
$remote_owner = $r[0];
@ -53,7 +53,7 @@ function subthread_content(&$a) {
WHERE `contact`.`self` = 1 AND `contact`.`uid` = %d LIMIT 1",
intval($owner_uid)
);
if(count($r))
if(dbm::is_result($r))
$owner = $r[0];
if(! $owner) {
@ -75,7 +75,7 @@ function subthread_content(&$a) {
intval($_SESSION['visitor_id']),
intval($owner_uid)
);
if(count($r))
if(dbm::is_result($r))
$contact = $r[0];
}
if(! $contact) {