1
0
Fork 0

More usage of dbm::is_result($r) instead of count($r):

- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions

View file

@ -15,7 +15,7 @@ function search_saved_searches() {
intval(local_user())
);
if(count($r)) {
if(dbm::is_result($r)) {
$saved = array();
foreach($r as $rr) {
$saved[] = array(
@ -53,7 +53,7 @@ function search_init(&$a) {
intval(local_user()),
dbesc($search)
);
if(! count($r)) {
if(! dbm::is_result($r)) {
q("INSERT INTO `search` (`uid`,`term`) VALUES ( %d, '%s')",
intval(local_user()),
dbesc($search)
@ -220,7 +220,7 @@ function search_content(&$a) {
intval($a->pager['start']), intval($a->pager['itemspage']));
}
if(! count($r)) {
if(! dbm::is_result($r)) {
info( t('No results.') . EOL);
return $o;
}