Escape global namespaced get_app() calls

- Add deprecated status

src/BaseModule.php

@@ -88,7 +88,7 @@ abstract class BaseModule extends BaseObject
 	 */
 	public static function getFormSecurityToken($typename = '')
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$timestamp = time();
 		$sec_hash = hash('whirlpool', $a->user['guid'] . $a->user['prvkey'] . session_id() . $timestamp . $typename);
@@ -116,7 +116,7 @@ abstract class BaseModule extends BaseObject
 
 		$max_livetime = 10800; // 3 hours
 
-		$a = get_app();
+		$a = \get_app();
 
 		$x = explode('.', $hash);
 		if (time() > (IntVal($x[0]) + $max_livetime)) {
@@ -136,7 +136,7 @@ abstract class BaseModule extends BaseObject
 	public static function checkFormSecurityTokenRedirectOnError($err_redirect, $typename = '', $formname = 'form_security_token')
 	{
 		if (!self::checkFormSecurityToken($typename, $formname)) {
-			$a = get_app();
+			$a = \get_app();
 			Logger::log('checkFormSecurityToken failed: user ' . $a->user['guid'] . ' - form element ' . $typename);
 			Logger::log('checkFormSecurityToken failed: _REQUEST data: ' . print_r($_REQUEST, true), Logger::DATA);
 			notice(self::getFormSecurityStandardErrorMessage());
@@ -147,7 +147,7 @@ abstract class BaseModule extends BaseObject
 	public static function checkFormSecurityTokenForbiddenOnError($typename = '', $formname = 'form_security_token')
 	{
 		if (!self::checkFormSecurityToken($typename, $formname)) {
-			$a = get_app();
+			$a = \get_app();
 			Logger::log('checkFormSecurityToken failed: user ' . $a->user['guid'] . ' - form element ' . $typename);
 			Logger::log('checkFormSecurityToken failed: _REQUEST data: ' . print_r($_REQUEST, true), Logger::DATA);
 			header('HTTP/1.1 403 Forbidden');

src/Content/OEmbed.php

@@ -56,7 +56,7 @@ class OEmbed
 	{
 		$embedurl = trim($embedurl, '\'"');
 
-		$a = get_app();
+		$a = \get_app();
 
 		$cache_key = 'oembed:' . $a->videowidth . ':' . $embedurl;
 
@@ -364,7 +364,7 @@ class OEmbed
 	 */
 	private static function iframe($src, $width, $height)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$height || strstr($height, '%')) {
 			$height = '200';

src/Content/Text/HTML.php

@@ -811,7 +811,7 @@ class HTML
 	public static function contactBlock()
 	{
 		$o = '';
-		$a = get_app();
+		$a = \get_app();
 
 		$shown = PConfig::get($a->profile['uid'], 'system', 'display_friend_count', 24);
 		if ($shown == 0) {

src/Content/Widget.php

@@ -44,7 +44,7 @@ class Widget
 	 */
 	public static function findPeople()
 	{
-		$a = get_app();
+		$a = \get_app();
 		$global_dir = Config::get('system', 'directory');
 
 		if (Config::get('system', 'invitation_only')) {
@@ -207,7 +207,7 @@ class Widget
 	 */
 	public static function categories($baseurl, $selected = '')
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!Feature::isEnabled($a->profile['profile_uid'], 'categories')) {
 			return '';
@@ -316,7 +316,7 @@ class Widget
 	 */
 	public static function tagCloud($limit = 50)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$a->profile['profile_uid'] || !$a->profile['url']) {
 			return '';

src/Content/Widget/CalendarExport.php

@@ -23,7 +23,7 @@ class CalendarExport
 	 * @return string Formated HTML of the calendar widget.
 	 */
 	public static function getHTML() {
-		$a = get_app();
+		$a = \get_app();
 
 		if (empty($a->data['user'])) {
 			return;

src/Core/Console/DocBloxErrorChecker.php

@@ -59,7 +59,7 @@ HELP;
 			throw new \RuntimeException('DocBlox isn\'t available.');
 		}
 
-		$dir = get_app()->getBasePath();
+		$dir = \get_app()->getBasePath();
 
 		//stack for dirs to search
 		$dirstack = [];

src/Core/Console/GlobalCommunityBlock.php

@@ -39,7 +39,7 @@ HELP;
 
 	protected function doExecute()
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if ($this->getOption('v')) {
 			$this->out('Class: ' . __CLASS__);

src/Core/Console/GlobalCommunitySilence.php

@@ -47,7 +47,7 @@ HELP;
 
 	protected function doExecute()
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if ($this->getOption('v')) {
 			$this->out('Class: ' . __CLASS__);

src/Core/Console/NewPassword.php

@@ -40,7 +40,7 @@ HELP;
 
 	protected function doExecute()
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if ($this->getOption('v')) {
 			$this->out('Class: ' . __CLASS__);

src/Core/Console/PhpToPo.php

@@ -51,7 +51,7 @@ HELP;
 			throw new \Asika\SimpleConsole\CommandArgsException('Too many arguments');
 		}
 
-		$a = get_app();
+		$a = \get_app();
 
 		$phpfile = realpath($this->getArgument(0));
 

src/Core/Console/PoToPhp.php

@@ -47,7 +47,7 @@ HELP;
 			throw new \Asika\SimpleConsole\CommandArgsException('Too many arguments');
 		}
 
-		$a = get_app();
+		$a = \get_app();
 
 		$pofile = realpath($this->getArgument(0));
 

src/Core/Console/Typo.php

@@ -41,7 +41,7 @@ HELP;
 			throw new \Asika\SimpleConsole\CommandArgsException('Too many arguments');
 		}
 
-		$a = get_app();
+		$a = \get_app();
 
 		$php_path = $a->getConfigValue('config', 'php_path', 'php');
 

src/Core/Theme.php

@@ -46,7 +46,7 @@ class Theme
 			return $info;
 		}
 
-		$a = get_app();
+		$a = \get_app();
 		$stamp1 = microtime(true);
 		$theme_file = file_get_contents("view/theme/$theme/theme.php");
 		$a->saveTimestamp($stamp1, "file");
@@ -155,13 +155,13 @@ class Theme
 		if ($root !== '' && $root[strlen($root) - 1] !== '/') {
 			$root = $root . '/';
 		}
-		$theme_info = get_app()->theme_info;
+		$theme_info = \get_app()->theme_info;
 		if (is_array($theme_info) && array_key_exists('extends', $theme_info)) {
 			$parent = $theme_info['extends'];
 		} else {
 			$parent = 'NOPATH';
 		}
-		$theme = get_app()->getCurrentTheme();
+		$theme = \get_app()->getCurrentTheme();
 		$thname = $theme;
 		$ext = substr($file, strrpos($file, '.') + 1);
 		$paths = [
@@ -191,7 +191,7 @@ class Theme
 	 */
 	public static function getStylesheetPath($theme)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$opts = (($a->profile_uid) ? '?f=&puid=' . $a->profile_uid : '');
 		if (file_exists('view/theme/' . $theme . '/style.php')) {

src/Core/Worker.php

@@ -35,7 +35,7 @@ class Worker
 	 */
 	public static function processQueue($run_cron = true)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		self::$up_start = microtime(true);
 
@@ -206,7 +206,7 @@ class Worker
 	 */
 	public static function execute($queue)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$mypid = getmypid();
 
@@ -319,7 +319,7 @@ class Worker
 	 */
 	private static function execFunction($queue, $funcname, $argv, $method_call)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$mypid = getmypid();
 

src/Database/DBA.php

@@ -208,7 +208,7 @@ class DBA
 	 * @param string $query The database query that will be analyzed
 	 */
 	private static function logIndex($query) {
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$a->getConfigVariable('system', 'db_log_index')) {
 			return;
@@ -388,7 +388,7 @@ class DBA
 	 * @return bool|object statement object or result object
 	 */
 	public static function p($sql) {
-		$a = get_app();
+		$a = \get_app();
 
 		$stamp1 = microtime(true);
 
@@ -606,7 +606,7 @@ class DBA
 	 * @return boolean Was the query successfull? False is returned only if an error occurred
 	 */
 	public static function e($sql) {
-		$a = get_app();
+		$a = \get_app();
 
 		$stamp = microtime(true);
 
@@ -770,7 +770,7 @@ class DBA
 	 * @return array current row
 	 */
 	public static function fetch($stmt) {
-		$a = get_app();
+		$a = \get_app();
 
 		$stamp1 = microtime(true);
 
@@ -1518,7 +1518,7 @@ class DBA
 	 * @return boolean was the close successful?
 	 */
 	public static function close($stmt) {
-		$a = get_app();
+		$a = \get_app();
 
 		$stamp1 = microtime(true);
 

src/Model/Contact.php

@@ -909,7 +909,7 @@ class Contact extends BaseObject
 	public static function photoMenu(array $contact, $uid = 0)
 	{
 		// @todo Unused, to be removed
-		$a = get_app();
+		$a = \get_app();
 
 		$contact_url = '';
 		$pm_url = '';
@@ -1631,7 +1631,7 @@ class Contact extends BaseObject
 	{
 		$result = ['cid' => -1, 'success' => false, 'message' => ''];
 
-		$a = get_app();
+		$a = \get_app();
 
 		// remove ajax junk, e.g. Twitter
 		$url = str_replace('/#!/', '/', $url);

src/Model/GContact.php

@@ -518,7 +518,7 @@ class GContact
 	 */
 	public static function updateSuggestions()
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$done = [];
 

src/Model/Item.php

@@ -1148,7 +1148,7 @@ class Item extends BaseObject
 		if ($notify) {
 			// We have to avoid duplicates. So we create the GUID in form of a hash of the plink or uri.
 			// We add the hash of our own host because our host is the original creator of the post.
-			$prefix_host = get_app()->getHostName();
+			$prefix_host = \get_app()->getHostName();
 		} else {
 			$prefix_host = '';
 
@@ -1238,7 +1238,7 @@ class Item extends BaseObject
 
 	public static function insert($item, $force_parent = false, $notify = false, $dontcache = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		// If it is a posting where users should get notifications, then define it as wall posting
 		if ($notify) {
@@ -2611,7 +2611,7 @@ class Item extends BaseObject
 
 	public static function isRemoteSelf($contact, &$datarray)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$contact['remote_self']) {
 			return false;

src/Model/Mail.php

@@ -28,7 +28,7 @@ class Mail
 	 */
 	public static function send($recipient = 0, $body = '', $subject = '', $replyto = '')
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$recipient) {
 			return -1;

src/Model/Photo.php

@@ -144,7 +144,7 @@ class Photo
 			$micro = System::baseUrl() . '/photo/' . $hash . '-6.' . $Image->getExt() . $suffix;
 
 			// Remove the cached photo
-			$a = get_app();
+			$a = \get_app();
 			$basepath = $a->getBasePath();
 
 			if (is_dir($basepath . "/photo")) {

src/Model/Profile.php

@@ -280,7 +280,7 @@ class Profile
 	 */
 	private static function sidebar($profile, $block = 0, $show_connect = true)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$o = '';
 		$location = false;
@@ -551,7 +551,7 @@ class Profile
 
 	public static function getBirthdays()
 	{
-		$a = get_app();
+		$a = \get_app();
 		$o = '';
 
 		if (!local_user() || $a->is_mobile || $a->is_tablet) {
@@ -649,7 +649,7 @@ class Profile
 
 	public static function getEventsReminderHTML()
 	{
-		$a = get_app();
+		$a = \get_app();
 		$o = '';
 
 		if (!local_user() || $a->is_mobile || $a->is_tablet) {
@@ -1090,7 +1090,7 @@ class Profile
 	 */
 	public static function openWebAuthInit($token)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		// Clean old OpenWebAuthToken entries.
 		OpenWebAuthToken::purge('owt', '3 MINUTE');

src/Model/User.php

@@ -406,7 +406,7 @@ class User
 	 */
 	public static function create(array $data)
 	{
-		$a = get_app();
+		$a = \get_app();
 		$return = ['user' => null, 'password' => ''];
 
 		$using_invites = Config::get('system', 'invitation_only');
@@ -795,7 +795,7 @@ class User
 			return false;
 		}
 
-		$a = get_app();
+		$a = \get_app();
 
 		Logger::log('Removing user: ' . $uid);
 

src/Network/FKOAuth1.php

@@ -36,7 +36,7 @@ class FKOAuth1 extends OAuthServer
 	public function loginUser($uid)
 	{
 		Logger::log("FKOAuth1::loginUser $uid");
-		$a = get_app();
+		$a = \get_app();
 		$record = DBA::selectFirst('user', [], ['uid' => $uid, 'blocked' => 0, 'account_expired' => 0, 'account_removed' => 0, 'verified' => 1]);
 
 		if (!DBA::isResult($record)) {

src/Network/Probe.php

@@ -74,7 +74,7 @@ class Probe
 	 */
 	private static function ownHost($host)
 	{
-		$own_host = get_app()->getHostName();
+		$own_host = \get_app()->getHostName();
 
 		$parts = parse_url($host);
 

src/Object/Image.php

@@ -652,7 +652,7 @@ class Image
 
 		$string = $this->asString();
 
-		$a = get_app();
+		$a = \get_app();
 
 		$stamp1 = microtime(true);
 		file_put_contents($path, $string);
@@ -730,7 +730,7 @@ class Image
 		Logger::log('Image: guessType: '.$filename . ($fromcurl?' from curl headers':''), Logger::DEBUG);
 		$type = null;
 		if ($fromcurl) {
-			$a = get_app();
+			$a = \get_app();
 			$headers=[];
 			$h = explode("\n", $header);
 			foreach ($h as $l) {
@@ -798,7 +798,7 @@ class Image
 				} else {
 					$tempfile = tempnam(get_temppath(), "cache");
 
-					$a = get_app();
+					$a = \get_app();
 					$stamp1 = microtime(true);
 					file_put_contents($tempfile, $img_str);
 					$a->saveTimestamp($stamp1, "file");

src/Protocol/DFRN.php

@@ -137,7 +137,7 @@ class DFRN
 	 */
 	public static function feed($dfrn_id, $owner_nick, $last_update, $direction = 0, $onlyheader = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$sitefeed    = ((strlen($owner_nick)) ? false : true); // not yet implemented, need to rewrite huge chunks of following logic
 		$public_feed = (($dfrn_id) ? false : true);
@@ -1160,7 +1160,7 @@ class DFRN
 	 */
 	public static function deliver($owner, $contact, $atom, $dissolve = false, $legacy_transport = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		// At first try the Diaspora transport layer
 		if (!$dissolve && !$legacy_transport) {
@@ -1420,7 +1420,7 @@ class DFRN
 	 */
 	public static function transmit($owner, $contact, $atom, $public_batch = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$public_batch) {
 			if (empty($contact['addr'])) {
@@ -1894,7 +1894,7 @@ class DFRN
 	 */
 	private static function processSuggestion($xpath, $suggestion, $importer)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		Logger::log("Processing suggestions");
 
@@ -2457,7 +2457,7 @@ class DFRN
 
 		/// @todo Do we really need this check for HTML elements? (It was copied from the old function)
 		if ((strpos($item['body'], '<') !== false) && (strpos($item['body'], '>') !== false)) {
-			$base_url = get_app()->getBaseURL();
+			$base_url = \get_app()->getBaseURL();
 			$item['body'] = HTML::relToAbs($item['body'], $base_url);
 
 			$item['body'] = HTML::toBBCodeVideo($item['body']);

src/Protocol/Diaspora.php

@@ -2305,7 +2305,7 @@ class Diaspora
 	 */
 	private static function receiveRequestMakeFriend(array $importer, array $contact)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if ($contact["rel"] == Contact::SHARING) {
 			DBA::update(
@@ -3064,7 +3064,7 @@ class Diaspora
 	 */
 	public static function transmit(array $owner, array $contact, $envelope, $public_batch, $queue_run = false, $guid = "", $no_queue = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$enabled = intval(Config::get("system", "diaspora_enabled"));
 		if (!$enabled) {

src/Protocol/Feed.php

@@ -35,7 +35,7 @@ class Feed {
 	 */
 	public static function import($xml, $importer, &$contact, &$hub, $simulate = false) {
 
-		$a = get_app();
+		$a = \get_app();
 
 		if (!$simulate) {
 			Logger::log("Import Atom/RSS feed '".$contact["name"]."' (Contact ".$contact["id"].") for user ".$importer["uid"], Logger::DEBUG);

src/Protocol/OStatus.php

@@ -1266,7 +1266,7 @@ class OStatus
 	 */
 	private static function addHeader(DOMDocument $doc, array $owner, $filter, $feed_mode = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$root = $doc->createElementNS(NAMESPACE_ATOM1, 'feed');
 		$doc->appendChild($root);

src/Protocol/PortableContact.php

@@ -63,7 +63,7 @@ class PortableContact
 	 */
 	public static function load($cid, $uid, $zcid, $url)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		if ($cid) {
 			if (!$url || !$uid) {

src/Render/FriendicaSmarty.php

@@ -22,7 +22,7 @@ class FriendicaSmarty extends Smarty
 	{
 		parent::__construct();
 
-		$a = get_app();
+		$a = \get_app();
 		$theme = $a->getCurrentTheme();
 
 		// setTemplateDir can be set to an array, which Smarty will parse in order.

src/Render/FriendicaSmartyEngine.php

@@ -32,7 +32,7 @@ class FriendicaSmartyEngine implements ITemplateEngine
 			$s = new FriendicaSmarty();
 		}
 
-		$r['$APP'] = get_app();
+		$r['$APP'] = \get_app();
 
 		// "middleware": inject variables into templates
 		$arr = [
@@ -54,7 +54,7 @@ class FriendicaSmartyEngine implements ITemplateEngine
 
 	public function getTemplateFile($file, $root = '')
 	{
-		$a = get_app();
+		$a = \get_app();
 		$template = new FriendicaSmarty();
 
 		// Make sure $root ends with a slash /

src/Util/ExAuth.php

@@ -122,7 +122,7 @@ class ExAuth
 	 */
 	private function isUser(array $aCommand)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		// Check if there is a username
 		if (!isset($aCommand[1])) {
@@ -202,7 +202,7 @@ class ExAuth
 	 */
 	private function auth(array $aCommand)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		// check user authentication
 		if (sizeof($aCommand) != 4) {

src/Util/Network.php

@@ -94,7 +94,7 @@ class Network
 
 		$stamp1 = microtime(true);
 
-		$a = get_app();
+		$a = \get_app();
 
 		$parts = parse_url($url);
 		$path_parts = explode('/', defaults($parts, 'path', ''));
@@ -251,7 +251,7 @@ class Network
 			return CurlResult::createErrorCurl($url);
 		}
 
-		$a = get_app();
+		$a = \get_app();
 		$ch = curl_init($url);
 
 		if (($redirects > 8) || (!$ch)) {
@@ -604,7 +604,7 @@ class Network
 	 */
 	public static function finalUrl($url, $depth = 1, $fetchbody = false)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$url = self::stripTrackingQueryParams($url);
 

src/Util/ParseUrl.php

@@ -111,7 +111,7 @@ class ParseUrl
 	 */
 	public static function getSiteinfo($url, $no_guessing = false, $do_oembed = true, $count = 1)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		$siteinfo = [];
 

src/Util/Temporal.php

@@ -126,7 +126,7 @@ class Temporal
 	 */
 	public static function getDateofBirthField($dob)
 	{
-		$a = get_app();
+		$a = \get_app();
 
 		list($year, $month, $day) = sscanf($dob, '%4d-%2d-%2d');