39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type
2022-06-18 23:30:37 +02:00
6f1d52cf71
Changed back to suggestions by @MrPetovan
2022-06-18 23:24:08 +02:00
fa14a02a19
Changes:
...
- added type-hints
- added documentation
- changed double-quotes to single
2022-06-18 23:12:52 +02:00
f3b57008b5
Proper type is string
2022-06-18 18:41:16 +02:00
41f34c4261
Maybe fix for:
...
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
2022-06-18 18:30:50 +02:00
9691bb06fb
Changes:
...
- added more type-hints
- added missing documentation
2022-06-18 18:21:29 +02:00
94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted
...
when you have DI::config() around.
2022-06-18 17:56:33 +02:00
c29c49797a
Added missing type-hints
2022-06-18 17:52:46 +02:00
4e437190c5
Renamed variable, no need for "orig_" prefix
2022-06-18 17:50:11 +02:00
a1a81cdc6b
Continued:
...
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
2022-06-18 17:46:34 +02:00
8fc710f82a
Continued:
...
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
2022-06-18 17:22:50 +02:00
8ba3f13fae
Changes:
...
- added more type-hints
- added missing documentation
2022-06-18 17:09:46 +02:00
7ec07178c8
Changes:
...
- added missing type-hints
- added missing documentation
2022-06-18 16:59:23 +02:00
8756d92316
Continued:
...
- prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
2022-06-18 15:57:31 +02:00
bd3a7b9877
Ops, needs to be a variable:
...
Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36
2022-06-18 09:59:19 +02:00
69cda4f760
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be
...
of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php
on line 37"
2022-06-18 05:42:02 +02:00
7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch()
...
is the same and being handled over.
2022-06-18 05:19:24 +02:00
89302d0843
Some outside code relies on returned "false"
2022-06-18 05:06:18 +02:00
aaf5c323b6
Fixed indenting
2022-06-18 05:04:14 +02:00
adb4aea6ad
Changes:
...
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
2022-06-18 05:03:10 +02:00
88c40f3336
Ops, wrong type again
2022-06-17 17:18:31 +02:00
a770634b95
Ops, wrong type
2022-06-17 17:18:31 +02:00
36d56a4041
Continued:
...
- changed back to 'return false;' as other methods heavily rely on false instead
of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
code more crazier than it already is (see APContact::getByURL())
2022-06-17 17:18:31 +02:00
c467bff79f
Some more type-hints added
2022-06-17 17:18:31 +02:00
4f3321cc9f
Nore fixes
2022-06-17 17:18:31 +02:00
10bb7d5625
Possible fix for
...
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
2022-06-17 17:18:31 +02:00
fdd237a090
Fix for "Uncaught Exception TypeError: "Argument 1 passed to
...
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
2022-06-17 17:18:31 +02:00
605e7d55b3
Continued:
...
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
changed it to -1 to have a proper type-hint
2022-06-17 17:18:31 +02:00
0c9aff8a09
Also need to declare $profile or otherwise an invocation of
...
Receiver::getReceiverForActor() will fail.
2022-06-17 17:18:31 +02:00
af8cd5ca86
Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(
2022-06-17 17:18:31 +02:00
227bab43a8
Ops, wrong type-hint here, must be string ($nickname can never be an integer).
2022-06-17 17:18:31 +02:00
f7c1eaa858
Continued:
...
- added type-hints
- removed out-dated documentation
- added some missing documentation
2022-06-17 17:18:31 +02:00
e484b6d6dc
Continued:
...
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
2022-06-17 17:18:31 +02:00
45b5f67bca
Fix for non-existing record system.mobile_theme in config table
2022-06-17 17:18:31 +02:00
5c9ce790bf
Fixed:
...
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
parameter expect it to be string
2022-06-17 17:18:31 +02:00
33768ea1c6
Some fixes:
...
- $gsid's default value cannot sadly be 0, it now must be null to allow some
code work
- added some more type-hints
- documented a bit more
2022-06-17 17:18:31 +02:00
4e53666c70
Added more type-hints
2022-06-17 17:18:31 +02:00
7560dccc08
Added again more type-hints
2022-06-17 17:18:31 +02:00
2766c7d9cf
Continued:
...
- added more type-hints
- added some missing documentation
2022-06-17 17:18:31 +02:00
a587217f47
Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"
2022-06-17 17:18:31 +02:00
dd54e52575
MrPetovan brought the right one up:
...
> Since this is depending on remote systems, the log can quickly fill with unactionable messages.
2022-06-17 17:18:31 +02:00
c351099c5a
Ops, bad type-hint here
2022-06-17 17:18:31 +02:00
2c5595c358
Another incompatible method declaration fixed + type-hints added
2022-06-17 17:18:31 +02:00
40d7f29a11
Continued:
...
- more type-hints
- fixed incompatible method declarations
2022-06-17 17:18:31 +02:00
1edc6b3c3b
Added more type-hints for "App" classes
2022-06-17 17:18:31 +02:00
42b04f397b
Added more type-hints
2022-06-17 17:18:31 +02:00
aa5f0d5ec1
Added more type-hints and documented a few methods
2022-06-17 17:18:31 +02:00
97e27cb523
Added more type-hints
2022-06-17 17:18:31 +02:00
c2e889cfae
Added more type-hints
2022-06-17 17:18:31 +02:00
5106bb2881
Added parenthesis
2022-06-17 09:41:11 +02:00
a903dbd77e
Wrong braces causing 'undefined index causer-id'. See #11632
2022-06-16 23:00:16 +02:00
6035de6883
Continued:
...
- added more type-hints
- also cannot return FALSE when array is set
2022-06-16 19:06:41 +02:00
51a7b5c584
Made also this one sweeter (null-coalscing)
2022-06-16 17:36:47 +02:00
0e1f734b03
Also make this null-coalscing
2022-06-16 17:35:01 +02:00
e8fee5644b
Ops, syntax errors get unnoticed with a simple editor. :-(
2022-06-16 17:10:02 +02:00
624e4c192c
Changed to null-coalscing style (??) as sugguested by @MrPetovan
2022-06-16 16:59:54 +02:00
962b06bf41
Added check as suggested by @MrPetovan for empty $message.
2022-06-16 16:54:51 +02:00
f2b7326650
This will 2 things:
...
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
been created, not even empty which could have side effects
Thanks to @annando to make me rethink this part of code.
2022-06-16 16:54:50 +02:00
7814ba4fc4
Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string)
2022-06-16 16:54:50 +02:00
b200874f17
Ops:
...
- wrong way around (!empty($foo)) is proper
- also needed to be checked on $acitivty['content']
2022-06-16 16:54:50 +02:00
b1e4c0931a
Fixes and type-hints:
...
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
argument, thanks to @tobias@social.diekershoff.de pointing this out.
2022-06-16 16:54:49 +02:00
e9af4b5bb9
Shorter code, thanks to @annando pointing this out
2022-06-16 13:29:30 +02:00
65da5246ca
Fixed possibble "Trying to access array offset on value of type bool" E_NOTICE
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-16 10:07:41 +02:00
5fa954208a
Changes:
...
- ops, wasn't actually fixing `return;` to proper `return '';`
- added more type-hints
- added TODO ($uid is unused)
2022-06-15 22:28:33 +02:00
a3fa95e8e4
Changes:
...
- added more type-hints
- changed `return;` to `return '';` when `string` was requested as returned type-hint
(thanks to @MrPetovan )
2022-06-15 22:05:38 +02:00
34aee64349
Added more type-hints
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:51 +02:00
143e4c4a18
Added more known type-hints
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:50 +02:00
726c4dff7d
You can now store the avatar in a separate folder and host
2022-06-15 03:59:26 +00:00
b816ae4db5
Some more default avatars
2022-06-13 20:07:54 +00:00
70b9a8114d
Improve license comment
2022-06-13 10:30:21 +00:00
d9fb081db9
Using separate avatars for different peertube account types
2022-06-13 10:27:46 +00:00
c1a64b77c0
Improved license text
2022-06-13 10:03:34 +00:00
e0a0c57c44
Use platform specific default avatar pictures
2022-06-13 05:18:54 +00:00
d7d8a6ab55
Issue 11625: Don't parse the title through Markdown
2022-06-11 06:50:59 +00:00
4cf46b9770
API: Use the type field in the query for pinned posts
2022-06-11 06:05:55 +00:00
176f0c1216
API: Improve the performance for fetching pinned posts
2022-06-10 22:38:46 +00:00
143120b9c4
Merge pull request #11626 from annando/api-status
...
API: Speed improvements when fetching posts
2022-06-10 16:52:05 -04:00
4157f816f5
Fix for account variable name
2022-06-10 20:32:21 +00:00
9a1abda314
Use "avatar" instead of "contact"
2022-06-10 20:26:57 +00:00
7e747b2f41
API: Speed improvements when fetching posts
2022-06-10 18:49:03 +00:00
37405567c1
Merge pull request #11622 from Quix0r/fixes/switch-db-current-max-update
...
Switched maximum database update with currently worked on to "current/max
2022-06-08 11:22:38 -04:00
1e890e16ac
Switched maximum database update with currently worked on to "current/max" as
...
this is understandable that update X of maximum Y is applied.
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-08 11:48:05 +02:00
2064a2ce87
Avoid notice when a contact couldn't be fetched
2022-06-08 05:35:34 +00:00
d2772908e4
Fix: respected the account type on the community page update
2022-06-07 18:52:46 +00:00
56e88d2c4c
Fix the spelling
2022-06-06 21:52:47 +00:00
19772f29f3
API: Support for markers added
2022-06-06 21:38:59 +00:00
9c7568cffc
Merge pull request #11612 from annando/rearrange
...
Rearrange the notification settings
2022-06-06 07:33:23 -04:00
9bb371850a
Different approach for empty values
2022-06-06 07:35:28 +00:00
a07e47f50c
Improved handling with empty user configuration
2022-06-06 05:43:24 +00:00
62701b49e1
Use constants
2022-06-06 04:44:29 +00:00
da33517a2d
Rearrange the notification settings
2022-06-05 21:19:21 +00:00
557b1125e2
Hopefully make threads writable
2022-06-05 20:38:05 +00:00
1196df4895
Remove test
2022-06-05 18:16:50 +00:00
001aac9952
Issue 11602: Fix error during contact merhe
2022-06-05 18:15:10 +00:00
9daeb552dd
Suppress dislikes
2022-06-05 16:54:29 +00:00
24559b711b
Notify about shared posts again
2022-06-05 16:26:20 +00:00
d242332aa4
Add the notify type to the notification query
2022-06-05 15:02:03 +00:00
13e216032f
Use the user id instead of "local_user()"
2022-06-05 14:22:16 +00:00
57b8708425
Issue 11566: More detailled notification configuration
2022-06-05 11:41:08 +00:00
b1afcb5ebf
Merge pull request #11588 from annando/mergecontact
...
New command to merge duplicated contacts
2022-06-04 15:34:37 -04:00
f1913b28e0
Issue 11594: Ensure to create notifications in the user language
2022-06-04 14:08:11 +00:00
50a0034744
Fix avatar for messages and feeds
2022-06-04 07:57:11 +00:00
4108704ee3
Fix: Only public posts can be pinned
2022-06-04 06:11:32 +00:00
194f0f7058
No dropping
2022-06-03 20:14:38 +00:00
6e3b5d251e
Merge pull request #11596 from annando/visible-activities
...
Fix: Like/Dislike/Reshare actions should now be visible
2022-06-03 15:54:49 -04:00
0aee9a054a
Fix: Like/Dislike/Reshare actions should now be visible
2022-06-03 17:40:06 +00:00
5442d09cc1
Ensure that the avatar base path exists
2022-06-03 05:28:10 +00:00
b794c599a9
Standards fixed
2022-06-01 22:18:18 +00:00
e46354a522
New command to merge duplicated contacts
2022-06-01 22:11:03 +00:00
7b219718c4
Fix: Use correct follow notification texts
2022-05-31 14:02:43 +00:00
cc6192df02
Issue 10926: Transmit pending events to accepted contacts
2022-05-30 20:52:43 +00:00
7f711e266f
Assume unsettable system.always_my_theme pconfig value is always true
...
- This was a logged in user setting so it assumes false for anonymous users
2022-05-29 16:13:49 -04:00
220703575c
Merge pull request #11577 from annando/issue-11557
...
Issue 11557: Update all local contacts
2022-05-29 15:53:21 -04:00
1e68c90fb2
Merge pull request #11576 from annando/issue-11488
...
Issue 11488: Don't search for mentions in shared posts
2022-05-29 15:49:46 -04:00
540b3f892b
Issue 11557: Update all local contacts
2022-05-29 17:48:09 +00:00
1301a53f20
Remove relocation form from Admin Site settings
2022-05-29 13:15:23 -04:00
f1630ebb05
Add relocate console command
2022-05-29 13:13:59 -04:00
7d09ce86c4
Move relocation feature in its separate class
...
- Create Database->replaceInTableFields method
2022-05-29 12:11:18 -04:00
42d3e5c1ce
Issue 11488: Don't search for mentions in shared posts
2022-05-29 16:07:53 +00:00
697b8a6cb8
Merge pull request #11575 from annando/issue-11469
...
Issue 11469: Respect desktop notification settings
2022-05-29 08:06:32 -04:00
1dccc31508
Issue 11469: Repect desktop notification settings
2022-05-29 09:20:06 +00:00
02473d8a0e
Don't touch local avatars
2022-05-29 06:50:34 +00:00
faa3f26d3b
Merge pull request #11570 from annando/issue-11470
...
Issue 11470: Check for removed account
2022-05-28 18:32:21 -04:00
a503d5ac1b
Merge pull request #11569 from annando/issue-11431
...
Issue 11431: Only show pinned posts on contacts and your own ones
2022-05-28 18:24:37 -04:00
4ef7f42257
Issue 11470: Check for removed account
2022-05-28 16:21:41 +00:00
881c4204b4
Issue 11431: Only show pinned posts on contacts and your own ones
2022-05-28 15:55:31 +00:00
ba8088bf3c
Add timestamp data to the avatar path
2022-05-28 14:20:48 +00:00
b05aa824f7
Don't move mail and feed
2022-05-27 06:32:19 +00:00
0a43fe857c
Pass the "force" parameter to the avatar update
2022-05-27 05:36:07 +00:00
8c901ebd74
Issue-11560: Fix error when creating avatar cache file
2022-05-26 19:06:16 +00:00
488fdd9791
Merge pull request #11558 from annando/public-contact
...
Ensure that the public contact exists before adding a user contact
2022-05-25 09:06:13 -04:00
918c1eeb56
Check for phantom network
2022-05-25 11:46:58 +00:00
f5d69b3b6a
Ensure that the public contact exixts before adding a user contact
2022-05-25 11:43:29 +00:00
e8864653d8
Merge remote-tracking branch 'upstream/2022.05-rc' into move-to-avatar-cache
2022-05-25 05:38:50 +00:00
dadebdd061
Change output function
2022-05-25 05:24:31 +00:00
Michael Vogel
e5e509ea21
Calculate totals
2022-05-24 22:32:30 +02:00
2fbfc0633a
Fixed placeholder
2022-05-24 20:12:39 +00:00
d3709d8497
Delete on invalid
2022-05-24 20:02:54 +00:00
9da0e637a3
Quit on invalid avatars
2022-05-24 19:47:49 +00:00
80adad3ad2
Additional method to fetch photo avatars
2022-05-24 19:41:38 +00:00
077c6ece64
Don't use a newline at the end
2022-05-24 17:51:28 +00:00
2ead69c7a5
Delete invalid photo data
2022-05-24 17:49:29 +00:00
Michael Vogel
0374f0e523
Use correct placeholder
2022-05-24 19:45:02 +02:00
0ff8ca8053
Trim the rid
2022-05-24 17:39:02 +00:00
Michael Vogel
eddfab7122
A space in front of a message looks better
2022-05-24 19:36:48 +02:00
f764ab7429
Improved messages
2022-05-24 17:33:10 +00:00
74b102b948
Increase the delivery queue counter on drop
2022-05-24 17:28:35 +00:00
bee6ffe968
Support dropping delivery for single message transfer as well
2022-05-24 12:32:04 +00:00
034d838248
Ignore delivery problems with drops
2022-05-24 12:27:35 +00:00
8969e83134
Use a better query to fetch the relay actor
2022-05-24 08:06:48 +00:00
