1
1
Fork 0

Merge pull request #9111 from annando/notice

Avoid notice "Undefined index: activity"
This commit is contained in:
Hypolite Petovan 2020-09-01 02:34:22 -04:00 committed by GitHub
commit dae3bcce0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -91,13 +91,14 @@ class Objects extends BaseModule
$data = ['@context' => ActivityPub::CONTEXT]; $data = ['@context' => ActivityPub::CONTEXT];
$data = array_merge($data, $activity['object']); $data = array_merge($data, $activity['object']);
} elseif (in_array($parameters['activity'], ['Create', 'Announce', 'Update', } elseif (empty($parameters['activity']) || in_array($parameters['activity'],
'Like', 'Dislike', 'Accept', 'Reject', 'TentativeAccept', 'Follow', 'Add', ''])) { ['Create', 'Announce', 'Update', 'Like', 'Dislike', 'Accept', 'Reject',
'TentativeAccept', 'Follow', 'Add'])) {
$data = ActivityPub\Transmitter::createActivityFromItem($item['id']); $data = ActivityPub\Transmitter::createActivityFromItem($item['id']);
if (empty($data)) { if (empty($data)) {
throw new HTTPException\NotFoundException(); throw new HTTPException\NotFoundException();
} }
if (!in_array($parameters['activity'], ['Create', ''])) { if (!empty($parameters['activity']) && ($parameters['activity'] != 'Create')) {
$data['type'] = $parameters['activity']; $data['type'] = $parameters['activity'];
$data['id'] = str_replace('/Create', '/' . $parameters['activity'], $data['id']); $data['id'] = str_replace('/Create', '/' . $parameters['activity'], $data['id']);
} }