Replace path parameter with query string parameter in Module\Search\Saved
This commit is contained in:
parent
c5f4f730e1
commit
74bf3a4dc8
|
@ -16,11 +16,11 @@ class Saved extends BaseModule
|
|||
$args = self::getClass(Arguments::class);
|
||||
|
||||
$action = $args->get(2, 'none');
|
||||
$search = Strings::escapeTags(trim(rawurldecode($args->get(3, ''))));
|
||||
$search = Strings::escapeTags(trim(rawurldecode($_GET['term'] ?? '')));
|
||||
|
||||
$return_url = $_GET['return_url'] ?? 'search?q=' . urlencode($search);
|
||||
|
||||
if (local_user()) {
|
||||
if (local_user() && $search) {
|
||||
switch ($action) {
|
||||
case 'add':
|
||||
$fields = ['uid' => local_user(), 'term' => $search];
|
||||
|
|
|
@ -191,8 +191,8 @@ return [
|
|||
'/search' => [
|
||||
'[/]' => [Module\Search\Index::class, [R::GET]],
|
||||
'/acl' => [Module\Search\Acl::class, [R::GET, R::POST]],
|
||||
'/saved/add/{term}' => [Module\Search\Saved::class, [R::GET]],
|
||||
'/saved/remove/{term}' => [Module\Search\Saved::class, [R::GET]],
|
||||
'/saved/add' => [Module\Search\Saved::class, [R::GET]],
|
||||
'/saved/remove' => [Module\Search\Saved::class, [R::GET]],
|
||||
],
|
||||
|
||||
'/settings' => [
|
||||
|
|
|
@ -11,7 +11,7 @@
|
|||
{{/if}}
|
||||
<input type="submit" name="submit" id="search-submit" value="{{$search_label}}"/>
|
||||
{{if $s}}
|
||||
<a href="search/saved/add/{{$q}}?return_url={{$return_url}}">{{$save_label}}</a>
|
||||
<a href="search/saved/add?term={{$q}}&return_url={{$return_url}}">{{$save_label}}</a>
|
||||
{{/if}}
|
||||
{{/strip}}
|
||||
</form>
|
||||
|
|
|
@ -6,7 +6,7 @@
|
|||
<ul role="menu" id="saved-search-ul">
|
||||
{{foreach $saved as $search}}
|
||||
<li role="menuitem" class="saved-search-li clear">
|
||||
<a href="search/saved/remove/{{$search.encodedterm}}?return_url={{$return_url}}" title="{{$search.delete}}" onclick="return confirmDelete();" id="drop-saved-search-term-{{$search.id}}" class="iconspacer savedsearchdrop"></a>
|
||||
<a href="search/saved/remove?term={{$search.encodedterm}}&return_url={{$return_url}}" title="{{$search.delete}}" onclick="return confirmDelete();" id="drop-saved-search-term-{{$search.id}}" class="iconspacer savedsearchdrop"></a>
|
||||
<a href="search?q={{$search.encodedterm}}" id="saved-search-term-{{$search.id}}" class="savedsearchterm">{{$search.term}}</a>
|
||||
</li>
|
||||
{{/foreach}}
|
||||
|
|
|
@ -2312,7 +2312,7 @@ ul.dropdown-menu li:hover {
|
|||
.search-content-wrapper > .section-title-wrapper {
|
||||
display: none;
|
||||
}
|
||||
#navbar-button > #search-save-form > #search-save {
|
||||
#navbar-button > #search-save {
|
||||
margin-top: 3px;
|
||||
}
|
||||
/* Section-Content-Wrapper */
|
||||
|
|
|
@ -169,7 +169,7 @@ $(document).ready(function(){
|
|||
}
|
||||
|
||||
// move the "Save the search" button to the second navbar
|
||||
$(".search-content-wrapper #search-save-form ").appendTo("#topbar-second > .container > #navbar-button");
|
||||
$(".search-content-wrapper #search-save").appendTo("#topbar-second > .container > #navbar-button");
|
||||
|
||||
// append the vcard-short-info to the second nav after passing the element
|
||||
// with .fn (vcard username). Use scrollspy to get the scroll position.
|
||||
|
|
|
@ -18,7 +18,7 @@ Some parts of this template will be moved by js to other places (see theme.js) -
|
|||
<div class="col-md-8">
|
||||
{{* The button to save searches *}}
|
||||
{{if $s}}
|
||||
<a href="search/saved/add/{{$q}}?return_url={{$return_url}}" class="btn btn-primary btn-small pull-right">{{$save_label}}</a>
|
||||
<a href="search/saved/add?term={{$q}}&return_url={{$return_url}}" class="btn btn-primary btn-small pull-right">{{$save_label}}</a>
|
||||
{{/if}}
|
||||
|
||||
{{* The select popup menu to select what kind of results the user would like to search for *}}
|
||||
|
@ -46,16 +46,13 @@ Some parts of this template will be moved by js to other places (see theme.js) -
|
|||
</div>
|
||||
|
||||
{{if $s}}
|
||||
<form id="search-save-form" action="search/saved/add/{{$q}}" method="get">
|
||||
<input type="hidden" name="return_url" value="{{$return_url}}">
|
||||
<button class="btn btn-sm btn-main pull-right" type="submit" id="search-save" title="{{$save_label}}" aria-label="{{$save_label}}" value="{{$save_label}}" data-toggle="tooltip">
|
||||
<a href="search/saved/add?term={{$q}}&return_url={{$return_url}}" class="btn btn-sm btn-main pull-right" id="search-save" title="{{$save_label}}" aria-label="{{$save_label}}" value="{{$save_label}}" data-toggle="tooltip">
|
||||
{{if $mode == "tag"}}
|
||||
<i class="fa fa-plus fa-2x" aria-hidden="true"></i>
|
||||
{{else}}
|
||||
<i class="fa fa-floppy-o fa-2x" aria-hidden="true"></i>
|
||||
{{/if}}
|
||||
<span class="sr-only">{{$save_label}}</span>
|
||||
</button>
|
||||
</form>
|
||||
</a>
|
||||
{{/if}}
|
||||
</div>
|
||||
|
|
|
@ -6,7 +6,7 @@
|
|||
<ul role="menu" id="saved-search-ul">
|
||||
{{foreach $saved as $search}}
|
||||
<li role="menuitem" class="saved-search-li clear">
|
||||
<a href="search/saved/remove/{{$search.encodedterm}}?return_url={{$return_url}}" title="{{$search.delete}}" onclick="return confirmDelete();" id="drop-saved-search-term-{{$search.id}}" class="savedsearchdrop pull-right widget-action faded-icon">
|
||||
<a href="search/saved/remove?term={{$search.encodedterm}}&return_url={{$return_url}}" title="{{$search.delete}}" onclick="return confirmDelete();" id="drop-saved-search-term-{{$search.id}}" class="savedsearchdrop pull-right widget-action faded-icon">
|
||||
<i class="fa fa-trash" aria-hidden="true"></i>
|
||||
</a>
|
||||
<a href="search?q={{$search.encodedterm}}" id="saved-search-term-{{$search.id}}" class="savedsearchterm">{{$search.term}}</a>
|
||||
|
|
|
@ -5,7 +5,7 @@
|
|||
{{foreach $saved as $search}}
|
||||
<li class="tool {{if $search.selected}}selected{{/if}}">
|
||||
<a href="search?q={{$search.encodedterm}}" class="label">{{$search.term}}</a>
|
||||
<a href="search/saved/remove/{{$search.encodedterm}}?return_url={{$return_url}}" class="action icon s10 delete" title="{{$search.delete}}" onclick="return confirmDelete();"></a>
|
||||
<a href="search/saved/remove?term={{$search.encodedterm}}&return_url={{$return_url}}" class="action icon s10 delete" title="{{$search.delete}}" onclick="return confirmDelete();"></a>
|
||||
</li>
|
||||
{{/foreach}}
|
||||
</ul>
|
||||
|
|
Loading…
Reference in a new issue