Add Module\Profile\Common class

- Add Common tab in profile contacts templates
- Add routing to new module

src/Module/Profile/Common.php

@@ -0,0 +1,112 @@
+<?php
+/**
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Profile;
+
+use Friendica\Content\Nav;
+use Friendica\Content\Pager;
+use Friendica\Core\Protocol;
+use Friendica\Core\Renderer;
+use Friendica\Core\Session;
+use Friendica\Module;
+use Friendica\DI;
+use Friendica\Model\Contact;
+use Friendica\Model\Profile;
+use Friendica\Module\BaseProfile;
+use Friendica\Network\HTTPException;
+
+class Common extends BaseProfile
+{
+	public static function content(array $parameters = [])
+	{
+		if (DI::config()->get('system', 'block_public') && !Session::isAuthenticated()) {
+			throw new HTTPException\NotFoundException(DI::l10n()->t('User not found.'));
+		}
+
+		$a = DI::app();
+
+		Nav::setSelected('home');
+
+		$nickname = $parameters['nickname'];
+
+		Profile::load($a, $nickname);
+
+		if (empty($a->profile)) {
+			throw new HTTPException\NotFoundException(DI::l10n()->t('User not found.'));
+		}
+
+		$o = self::getTabsHTML($a, 'contacts', false, $nickname);
+
+		if (!empty($a->profile['hide-friends'])) {
+			throw new HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.'));
+		}
+
+		$displayCommonTab = Session::isAuthenticated() && $a->profile['uid'] != local_user();
+
+		if (!$displayCommonTab) {
+			$a->redirect('profile/' . $nickname . '/contacts');
+		};
+
+		$sourceId = Contact::getIdForURL(Profile::getMyURL());
+		$targetId = Contact::getPublicIdByUserId($a->profile['uid']);
+
+		$condition = [
+			'blocked' => false,
+			'deleted' => false,
+			'network' => [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, Protocol::FEED],
+		];
+
+		$total = Contact\Relation::countCommon($sourceId, $targetId, $condition);
+
+		$pager = new Pager(DI::l10n(), DI::args()->getQueryString());
+
+		$commonFollows = Contact\Relation::listCommon($sourceId, $targetId, $condition, $pager->getItemsPerPage(), $pager->getStart());
+
+		$contacts = array_map([Module\Contact::class, 'getContactTemplateVars'], $commonFollows);
+
+		$title = DI::l10n()->tt('Common contact (%s)', 'Common contacts (%s)', $total);
+		$desc = DI::l10n()->t(
+			'Both <strong>%s</strong> and yourself have publicly interacted with these contacts (follow, comment or likes on public posts).',
+			htmlentities($a->profile['name'], ENT_COMPAT, 'UTF-8')
+		);
+
+		$tpl = Renderer::getMarkupTemplate('profile/contacts.tpl');
+		$o .= Renderer::replaceMacros($tpl, [
+			'$title'    => $title,
+			'$desc'     => $desc,
+			'$nickname' => $nickname,
+			'$type'     => 'common',
+			'$displayCommonTab' => $displayCommonTab,
+
+			'$all_label'       => DI::l10n()->t('All contacts'),
+			'$followers_label' => DI::l10n()->t('Followers'),
+			'$following_label' => DI::l10n()->t('Following'),
+			'$mutuals_label'   => DI::l10n()->t('Mutual friends'),
+			'$common_label'    => DI::l10n()->t('Common'),
+			'$noresult_label'  => DI::l10n()->t('No common contacts.'),
+
+			'$contacts' => $contacts,
+			'$paginate' => $pager->renderFull($total),
+		]);
+
+		return $o;
+	}
+}

src/Module/Profile/Contacts.php

@@ -115,11 +115,13 @@ class Contacts extends Module\BaseProfile
 			'$desc'     => $desc,
 			'$nickname' => $nickname,
 			'$type'     => $type,
+			'$displayCommonTab' => Session::isAuthenticated() && $a->profile['uid'] != local_user(),
 
 			'$all_label'       => DI::l10n()->t('All contacts'),
 			'$followers_label' => DI::l10n()->t('Followers'),
 			'$following_label' => DI::l10n()->t('Following'),
 			'$mutuals_label'   => DI::l10n()->t('Mutual friends'),
+			'$common_label'    => DI::l10n()->t('Common'),
 			'$noresult_label'  => DI::l10n()->t('No contacts.'),
 
 			'$contacts' => $contacts,

static/routes.config.php

@@ -252,6 +252,7 @@ return [
 	'/profile' => [
 		'/{nickname}'                                         => [Module\Profile\Index::class,    [R::GET]],
 		'/{nickname}/profile'                                 => [Module\Profile\Profile::class,  [R::GET]],
+		'/{nickname}/contacts/common'                         => [Module\Profile\Common::class,   [R::GET]],
 		'/{nickname}/contacts[/{type}]'                       => [Module\Profile\Contacts::class, [R::GET]],
 		'/{nickname}/status[/{category}[/{date1}[/{date2}]]]' => [Module\Profile\Status::class,   [R::GET]],
 	],

view/templates/profile/contacts.tpl

@@ -10,6 +10,9 @@
 		<li role="menuitem"><a href="profile/{{$nickname}}/contacts/followers" class="tab button{{if $type == 'followers'}} active{{/if}}">{{$followers_label}}</a></li>
 		<li role="menuitem"><a href="profile/{{$nickname}}/contacts/following" class="tab button{{if $type == 'following'}} active{{/if}}">{{$following_label}}</a></li>
 		<li role="menuitem"><a href="profile/{{$nickname}}/contacts/mutuals" class="tab button{{if $type == 'mutuals'}} active{{/if}}">{{$mutuals_label}}</a></li>
+	{{if $displayCommonTab}}
+		<li role="menuitem"><a href="profile/{{$nickname}}/contacts/common" class="tab button{{if $type == 'common'}} active{{/if}}{{if !$common_count}} disabled{{/if}}">{{$common_label}}</a></li>
+	{{/if}}
 	</ul>
 {{if $contacts}}
 	<div id="viewcontact_wrapper-{{$id}}">

view/theme/frio/templates/profile/contacts.tpl

@@ -18,6 +18,11 @@
 		<li role="presentation"{{if $type == 'mutuals'}} class="active"{{/if}}>
 			<a href="profile/{{$nickname}}/contacts/mutuals">{{$mutuals_label}}</a>
 		</li>
+	{{if $displayCommonTab}}
+		<li role="presentation"{{if $type == 'common'}} class="active"{{/if}}>
+			<a href="profile/{{$nickname}}/contacts/common" class="tab button">{{$common_label}}</a>
+		</li>
+	{{/if}}
 	</ul>
 {{if $contacts}}
 	<ul id="viewcontact_wrapper{{if $id}}-{{$id}}{{/if}}" class="viewcontact_wrapper media-list">