bitPickups/friendica_2019-12_sharedHosting_hotFix
1
1
Fork 0
Code Pull requests Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/wall_attach.php
View file

@ -12,7 +12,7 @@ function wall_attach_post(&$a) {
$r = q("SELECT `user`.*, `contact`.`id` FROM `user` LEFT JOIN `contact` on `user`.`uid` = `contact`.`uid` WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 and `contact`.`self` = 1 LIMIT 1",
dbesc($nick)
);
if(! count($r)){
if(! dbm::is_result($r)){
if ($r_json) {
echo json_encode(array('error'=>t('Invalid request.')));
killme();
@ -55,7 +55,7 @@ function wall_attach_post(&$a) {
intval($contact_id),
intval($page_owner_uid)
);
if(count($r)) {
if(dbm::is_result($r)) {
$can_post = true;
$visitor = $contact_id;
}
@ -168,7 +168,7 @@ function wall_attach_post(&$a) {
dbesc($hash)
);
if(! count($r)) {
if(! dbm::is_result($r)) {
$msg = t('File upload failed.');
if ($r_json) {
echo json_encode(array('error'=>$msg));