bitPickups/friendica_2019-12_sharedHosting_hotFix
1
1
Fork 0
Code Pull requests Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/poco.php
View file

@ -45,7 +45,7 @@ function poco_init(&$a) {
where `user`.`nickname` = '%s' and `profile`.`is-default` = 1 limit 1",
dbesc($user)
);
if(! count($r) || $r[0]['hidewall'] || $r[0]['hide-friends'])
if(! dbm::is_result($r) || $r[0]['hidewall'] || $r[0]['hide-friends'])
http_status_exit(404);
$user = $r[0];
@ -83,7 +83,7 @@ function poco_init(&$a) {
dbesc(NETWORK_STATUSNET)
);
}
if(count($r))
if(dbm::is_result($r))
$totalResults = intval($r[0]['total']);
else
$totalResults = 0;
@ -173,7 +173,7 @@ function poco_init(&$a) {
}
if(is_array($r)) {
if(count($r)) {
if(count($r) > 0) {
foreach($r as $rr) {
if (!isset($rr['generation'])) {
if ($global)