More usage of dbm::is_result($r) instead of count($r):
- count() returns very different results and never a boolean (not even false on error condition). - therefore you should NOT use it in boolean expressions. This still *can* be done in PHP because of its lazyness. But it is discouraged if it comes to more clean code. Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
		
					parent
					
						
							
								293436e5fd
							
						
					
				
			
			
				commit
				
					
						6a8a36f12d
					
				
			
		
					 115 changed files with 439 additions and 437 deletions
				
			
		| 
						 | 
				
			
			@ -15,7 +15,7 @@ function manage_post(&$a) {
 | 
			
		|||
		$r = q("select * from user where uid = %d limit 1",
 | 
			
		||||
			intval($_SESSION['submanage'])
 | 
			
		||||
		);
 | 
			
		||||
		if(count($r)) {
 | 
			
		||||
		if(dbm::is_result($r)) {
 | 
			
		||||
			$uid = intval($r[0]['uid']);
 | 
			
		||||
			$orig_record = $r[0];
 | 
			
		||||
		}
 | 
			
		||||
| 
						 | 
				
			
			@ -56,7 +56,7 @@ function manage_post(&$a) {
 | 
			
		|||
		);
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if(! count($r))
 | 
			
		||||
	if(! dbm::is_result($r))
 | 
			
		||||
		return;
 | 
			
		||||
 | 
			
		||||
	unset($_SESSION['authenticated']);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue