bitPickups/friendica_2019-12_sharedHosting_hotFix
1
1
Fork 0
Code Pull requests Activity

Bugfixing empty password setting

Browse source
This commit is contained in:
Philipp Holzer 2019-06-10 15:39:21 +02:00
parent 357d9b5108
commit 4666b18e5b
No known key found for this signature in database
GPG key ID: D8365C3D36B77D90
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/Core/Config/Cache/ConfigCache.php
View file

@ -94,7 +94,8 @@ class ConfigCache implements IConfigCache, IPConfigCache
} }
if ($this->hidePasswordOutput && if ($this->hidePasswordOutput &&
$key == 'password') { $key == 'password' &&
!empty($value)) {
$this->config[$cat][$key] = new HiddenString($value); $this->config[$cat][$key] = new HiddenString($value);
} else { } else {
$this->config[$cat][$key] = $value; $this->config[$cat][$key] = $value;

16
tests/src/Core/Config/Cache/ConfigCacheTest.php
View file

@ -309,4 +309,20 @@ class ConfigCacheTest extends MockedTest
$this->assertEquals('supersecure', print_r($configCache->get('database', 'password'), true)); $this->assertEquals('supersecure', print_r($configCache->get('database', 'password'), true));
$this->assertEquals('notsecured', print_r($configCache->get('database', 'username'), true)); $this->assertEquals('notsecured', print_r($configCache->get('database', 'username'), true));
} }
/**
* Test a empty password
*/
public function testEmptyPassword()
{
$confiCache = new ConfigCache([
'database' => [
'password' => '',
'username' => '',
]
]);
$this->assertEmpty($confiCache->get('database', 'password'));
$this->assertEmpty($confiCache->get('database', 'username'));
}
} }