bitPickups/ad-aures_castoPod
1
0
Fork 0
mirror of https://github.com/ad-aures/castopod.git synced 2026-04-02 14:29:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(media): copy and delete temp file when saving instead of moving it for FS FileManager

Browse source 
+ throw exception instead silently failing file save

closes #338
This commit is contained in:
Yassine Doghri 2023-08-06 12:14:05 +00:00
commit 9346e787bd
10 changed files with 59 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

13
modules/Media/TranscriptParser.php
View file

@ -12,6 +12,7 @@ declare(strict_types=1);
namespace Modules\Media;
use Exception;
use stdClass;
class TranscriptParser
@ -27,8 +28,10 @@ class TranscriptParser
/**
* Adapted from: https://stackoverflow.com/a/11659306
*
* @return string Returns the json encoded string
*/
public function parseSrt(): string | false
public function parseSrt(): string
{
if (! defined('SRT_STATE_SUBNUMBER')) {
define('SRT_STATE_SUBNUMBER', 0);
@ -98,7 +101,13 @@ class TranscriptParser
$subs[] = $sub;
}
return json_encode($subs, JSON_PRETTY_PRINT);
$jsonString = json_encode($subs, JSON_PRETTY_PRINT);
if (! $jsonString) {
throw new Exception('Failed to parse SRT to JSON.');
}
return $jsonString;
}
private function getSecondsFromTimeString(string $timeString): float